font-patcher: remove_ligatures() never displays warnings #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I can second @fracsinus here, the marked four lines need to be 'one indent step' more to the left. Great find 👍 |
Collaborator
|
@fracsinus I would change the title to state what is the effect of the issue; at first I thought that the glyphs are indentat in the font file or something ;-D Something along the lines 'Remove ligature warnings never displayed' or so. |
Contributor
Author
|
@Finii Thanks for nice advice! Just changed the title 👍 |
Owner
|
Yes good find. I'll test it out soon. Thanks! |
Owner
|
yep that's how it was/is supposed to be |
Closed
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
font-patcher: remove_ligatures() never displays warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nerd-fonts/font-patcher
Lines 416 to 419 in bc4416e
It seems that the
elifblock is meant to check the case where:--removeligaturesis setI guess those blocks are over-indented? For now, no warning or info message is printed even in the very case.