Bugfix/fstype font does not open #687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] Through fsType certain restrictions can be set on a font. When fontforge is used in interactive mode the user can override the restrictions with a popup dialogue. The font-patcher script dies instead, without any meaningful message. [how] Allow the script to ignore fsType settings when opening. The restrictions will still persist into the generated patched font. [note] This came up with Bicubik by Anton Kudin, that has fsType = 2 (modification restriction) set. Fixes: #686 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] When fontforge is not able to open the font we fail with a meaninless exception. Users might think that the font-patcher script itself is broken. [how] Exit the script with a hint how to get more information if fontforge was not able to open the font. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
|
can confirm this works, thanks :D |
Owner
|
great. thanks. tested out. looks good. |
ryanoasis
added a commit
that referenced
this pull request
Nov 28, 2021
* the patcher refuses to patch all/most fonts with this flag in the open options
Owner
|
I had to revert part of this as that flag seems to be causing issues patching at all. see #691 At first I thought something changed with Cascadia Code but I tried the unpatched version in Nerd Fonts as well as Hack. Neither worked. Seems to work again now. |
4 tasks
Finii
added a commit
that referenced
this pull request
Nov 28, 2021
[why] With commit f7d6fcb font-patcher: Allow processing of fonts with fsType set we added support for fonts with the fsType set. This came up in issue #686 with font 'Bicubik'. The solution in that commit uses (modern) textual flags in the `fontforge` open() method. But they have been only introduced in 2020, so people using older `fontforge` could not patch anything anymore. This has been reported in issue #691. As a quick fix the fsType support has been removed with commit ab6fa3c Reverts part of #687 * the patcher refuses to patch all/most fonts with this flag in the open options [how] Revert f7d6fcb but use the old fashioned numerical open flags interface instead. [note] The textual open() flags have been introduced into `fontforge`s python interface with their commit fontforge/fontforge@4a76712 Font Open flag improvements * Document more Open flags * Add string tuple interface to python FontOpen API Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
…es-not-open Bugfix/fstype font does not open
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
* the patcher refuses to patch all/most fonts with this flag in the open options
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
[why] With commit f7d6fcb font-patcher: Allow processing of fonts with fsType set we added support for fonts with the fsType set. This came up in issue ryanoasis#686 with font 'Bicubik'. The solution in that commit uses (modern) textual flags in the `fontforge` open() method. But they have been only introduced in 2020, so people using older `fontforge` could not patch anything anymore. This has been reported in issue ryanoasis#691. As a quick fix the fsType support has been removed with commit ab6fa3c Reverts part of ryanoasis#687 * the patcher refuses to patch all/most fonts with this flag in the open options [how] Revert f7d6fcb but use the old fashioned numerical open flags interface instead. [note] The textual open() flags have been introduced into `fontforge`s python interface with their commit fontforge/fontforge@4a76712 Font Open flag improvements * Document more Open flags * Add string tuple interface to python FontOpen API Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
Requirements / Checklist
./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons./gotta-patch-em-all-font-patcher\!.sh HermitWhat does this Pull Request (PR) do?
2 commits:
font-patcher: Allow processing of fonts with fsType set
[why]
Through fsType certain restrictions can be set on a font. When fontforge
is used in interactive mode the user can override the restrictions with
a popup dialogue. The font-patcher script dies instead, without any
meaningful message.
[how]
Allow the script to ignore fsType settings when opening.
The restrictions will still persist into the generated patched font.
[note]
This came up with Bicubik by Anton Kudin, that has fsType = 2
(modification restriction) set.
Fixes: #686
font-patcher: Fail with meaningful message if font can not be opened
[why]
When fontforge is not able to open the font we fail with a meaninless
exception. Users might think that the font-patcher script itself is
broken.
[how]
Exit the script with a hint how to get more information if fontforge was
not able to open the font.