这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@astrolemonade
Copy link
Contributor

@astrolemonade astrolemonade commented Nov 17, 2021

Description

Please explain the changes you made here.

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • docker run -v ~/input:/in -v ~/output:/out patcher -c

What does this Pull Request (PR) do?

Make Docker setup work

Any background context you can provide?

  • build a new image and use the docker commands listed on the Readme

Screenshots (if appropriate or helpful)

image
Proof that the patched font has the expected symbols.

@astrolemonade
Copy link
Contributor Author

astrolemonade commented Nov 17, 2021

An update to the docker hub image after the merge would be really appreciated.

@ryanoasis
Copy link
Owner

An update to the docker hub image after the merge would be really appreciated.

Done, published. Docker publishing is now working/fixed after adding the secrets. From now on the workflow should publish it automatically.

@ryanoasis ryanoasis merged commit d2fe032 into ryanoasis:master Nov 27, 2021
@astrolemonade
Copy link
Contributor Author

Thank you

LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
Update Dockerfile to use latest alpine and py3-pip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants