Update contribution instructions with fontforge --script
#554
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following issue #225 it seems fontforge has updated how it behaves after installing. For a consistent experience across
various operating systems (Ubuntu, macOS, etc), it seems we get better results by pre-pending
fontforge --script ..before running the
font-patcherscript.Requirements / Checklist
./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons./gotta-patch-em-all-font-patcher\!.sh HermitWhat does this Pull Request (PR) do?
Updates the Contributing.md docs.
How should this be manually tested?
Verify that e.g.
fontforge --script ./font-patcher src/unpatched-fonts/Hasklig/Regular/Hasklig-Regular.otf --completealso works locally for you.If not, we should include both with and without.
Any background context you can provide?
While trying to follow the contribution instructions, the invocation of
font-patcherkeeps failing withRunning the following instead works:
Check out #225 for more context.
What are the relevant tickets (if any)?
#225
Screenshots (if appropriate or helpful)
N/A