Take the style from the filename if it's longer than the subfamily (fixes #257) #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanoasis
requested changes
Dec 1, 2020
Owner
ryanoasis
left a comment
There was a problem hiding this comment.
typo change, other comment is open ended question. Thanks for taking on this fix...
Fix "Subfmaily" typo
Contributor
Author
|
You know, I did fix the typo... |
Owner
|
Thanks! |
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
Take the style from the filename if it's longer than the subfamily (fixes ryanoasis#257)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The font patcher now takes the style ("Italic", "Regular", etc) from the filename if it's longer (contains more information) than the "subfamily".
Description
Updates the font patcher's algorithm for detecting the style (Italic, Regular, etc) in the font's Postscript name, so that it's more accurate.
When I first tested this with IBM Plex Mono 5.3.1, I could confirm that it fixes fixes #257 by successfully giving each generated font a unique Postscript name.
I have since tested it with VictorMono and JetBrainsMono. I have also imported all three into Font Book on OS X, and confirmed that this pull request does, indeed, resolve the issue.
Requirements / Checklist
./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons./gotta-patch-em-all-font-patcher\!.sh HermitWhat does this Pull Request (PR) do?
Fixes #257.
How should this be manually tested?
The literal command I used to test this is in my comment here:
#323 (comment)
After that, I did "fc-cache -f -v" and "kitty list-fonts --psnames", checking that each Blex Mono font file's Postscript name is unique.
Any background context you can provide?
I tested the font patcher on Fedora 32. I tested the results on Fedora 32 and on OS X.
What are the relevant tickets (if any)?
#257