这是indexloc提供的服务，不要输入任何密码
Skip to content

Update Cascadia Code to version 2007.01 #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2020
Merged

Update Cascadia Code to version 2007.01 #499

merged 2 commits into from
Dec 1, 2020

Conversation

@natebwangsut
Copy link
Contributor

@natebwangsut natebwangsut commented Jul 8, 2020 •
edited
Loading

Description

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

  • Update Cascadia Code to version 2007.11

@natebwangsut
Update cascadiacode to version 2007.01
cb56c00 
- Allowing weighted font families
- Fix #498
@natebwangsut
Copy link
Contributor Author

natebwangsut commented Jul 10, 2020

The CI failure is unrelated to PR

@ryanoasis
Copy link
Owner

ryanoasis commented Jul 29, 2020

That CI error should be fixed going forward. Thanks for the PR as well 👍 😄

@kppullin
Copy link

kppullin commented Aug 16, 2020

I noticed that the Mono version of the font contains ligatures which is contrary to this statement in the readme: By the Nerd Font policy, the variant with the 'Mono' suffix is not supposed to have any ligatures. Use the non-Mono variants to have ligatures. The 2007.01 mono version of Cascadia Code from the Microsoft repo does not contain ligatures so I'd guess they're added downstream of the source.

This also exists in the current version of the font in master and might be better suited to open a separate issue.

@adrian5
Copy link
Contributor

adrian5 commented Oct 6, 2020

Any progress on this? Was it mostly just a sporadic CI failure that a rerun fixes, or are the misplaced ligatures a show-stopper?

I'd like to use CaskaydiaCove with different font weights.

@natebwangsut
Copy link
Contributor Author

natebwangsut commented Oct 7, 2020

I noticed that the Mono version of the font contains ligatures which is contrary to this statement in the readme: By the Nerd Font policy, the variant with the 'Mono' suffix is not supposed to have any ligatures. Use the non-Mono variants to have ligatures. The 2007.01 mono version of Cascadia Code from the Microsoft repo does not contain ligatures so I'd guess they're added downstream of the source.

This also exists in the current version of the font in master and might be better suited to open a separate issue.

Yes the ligature was added by the patcher. There's a conflicting definition on what does "Mono" mean, however per nerd-font repository:

Features

Monospaced (fixed-pitch, fixed-width) or double-width (non-monospaced) glyphs version of each font. This refers to the Nerd Font glyphs themselves not necessarily the Font as a whole

So, IMO since the PR was on nerd-font repo, I don't see any issues here.

@natebwangsut
Copy link
Contributor Author

natebwangsut commented Oct 7, 2020

Any progress on this? Was it mostly just a sporadic CI failure that a rerun fixes, or are the misplaced ligatures a show-stopper?

I'd like to use CaskaydiaCove with different font weights.

I cannot rerun the CI job, only maintainer / owner can do. @ryanoasis can you please rerun the job?

@ryanoasis
Copy link
Owner

ryanoasis commented Dec 1, 2020

Not sure what's going on with the CI jobs but these changes look good. Thanks!

@ryanoasis ryanoasis merged commit a04f43b into ryanoasis:master Dec 1, 2020
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
@ryanoasis
Merge pull request ryanoasis#499 from natebwangsut/font/cascadiacode-…
9eb06d8 
…2007.01

Update Cascadia Code to version 2007.01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Patching Cascadia Code v2007 with Nerd Fonts patcher produces segmentation fault

4 participants

@natebwangsut @ryanoasis @kppullin @adrian5