这是indexloc提供的服务，不要输入任何密码
Skip to content

Update Fira Code to latest version #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 6, 2020
Merged

Update Fira Code to latest version #497

merged 3 commits into from
Sep 6, 2020

Conversation

@gitfool
Copy link
Contributor

@gitfool gitfool commented Jun 28, 2020 •
edited
Loading

Description

Updates Fira Code to latest version (v5.2). Fixes #464.

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
fontforge -script font-patcher src/unpatched-fonts/FiraCode/Bold/FiraCode-Bold.ttf
rm 'Fira Code Bold Nerd Font.ttf'

pushd bin/scripts
./standardize-and-complete-readmes.sh FiraCode
rm ../../patched-fonts/FiraCode/extras/font-info.md
./gotta-patch-em-all-font-patcher\!.sh FiraCode

popd
zip -9 FiraCode -rj patched-fonts/FiraCode -i '*.[o,t]tf'
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table
    • replaced Fira Code showcases with extras to align with the latest upstream

What does this Pull Request (PR) do?

Updates Fira Code to latest version (v5.2).

How should this be manually tested?

Install the font and try it in your favorite editor. I'm already using it in VS Code and Windows Terminal.

FiraCode.zip

Any background context you can provide?

What are the relevant tickets (if any)?

#464

Screenshots (if appropriate or helpful)

@gitfool
Copy link
Contributor Author

gitfool commented Jun 28, 2020 •
edited
Loading

@ryanoasis The build failure above is unrelated.

Note: I also added a Visual Studio Code .devcontainer so I could use Remote WSL and Remote Containers to make these changes; other contributors should find this useful too as it captures the development environment requirements.

Also, I've no idea how FiraCode/config.json was originally derived, so I'm not sure if I need to update it...

@gitfool gitfool mentioned this pull request Jun 28, 2020
Merged
5 tasks
@ryanoasis
Copy link
Owner

ryanoasis commented Jul 29, 2020

Thanks for updating it 😃 . I need to pull it down and check it out but sounds pretty reasonable

@ryanoasis ryanoasis merged commit 1cf59ff into ryanoasis:master Sep 6, 2020
@gitfool gitfool deleted the gh464 branch September 6, 2020 20:34
@Finii Finii mentioned this pull request Aug 31, 2022
Closed
@Finii Finii mentioned this pull request Jan 9, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Fira Code to latest version

2 participants

@gitfool @ryanoasis