这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@get-me-power
Copy link
Contributor

Description

Please explain the changes you made here.

I fixed CI's error.

shellcheck comes standard with travis. Therefore, there is no need to install it explicitly.
With this patch, lint will work properly.

reference

https://github.com/koalaman/shellcheck/wiki/TravisCI

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

Fix CI's error.

How should this be manually tested?

Nothing. Please see travis-ci's status.

Any background context you can provide?

https://travis-ci.org/github/kazukazuinaina/nerd-fonts/builds/699502908

It ispassing status in my fork repo.

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

@get-me-power get-me-power mentioned this pull request Jun 17, 2020
5 tasks
@get-me-power
Copy link
Contributor Author

ping @ryanoasis

@ryanoasis
Copy link
Owner

Ah okay. Good to know. Thanks

@ryanoasis
Copy link
Owner

I'm going to merge this since it's low risk and easy to review without pulling down the branch

@ryanoasis ryanoasis merged commit 4b269b2 into ryanoasis:master Jul 29, 2020
@get-me-power get-me-power deleted the fix_ci_error branch July 29, 2020 08:50
@get-me-power
Copy link
Contributor Author

get-me-power commented Jul 29, 2020

@ryanoasis
Thanks for your merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants