这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@LuanVSO
Copy link
Contributor

@LuanVSO LuanVSO commented Feb 6, 2020

Description

updated the font file, readme and ran the gotta-patch-em-all script

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

updates cascadia font to its latest release(1911.21)

How should this be manually tested?

run the patchers

Any background context you can provide?

updated it so that it includes some latim characters that the current version of the font on the repository does not include

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

@LuanVSO LuanVSO requested a review from ryanoasis February 6, 2020 14:16
@LuanVSO
Copy link
Contributor Author

LuanVSO commented Feb 6, 2020

running the gotta-patch-em-all script on the new file added "Regular" to patched file names, should i rename them back to what was before or leave in this way?

@ryanoasis
Copy link
Owner

I think leave it. It looks like they added 'Regular' to the font name. Just make sure to remove the old patched fonts since these new ones will have new names (to avoid having both where one set will be out of date).

Thanks!

@ryanoasis ryanoasis added this to the v2.2.0 milestone Feb 10, 2020
@LuanVSO
Copy link
Contributor Author

LuanVSO commented Feb 10, 2020

got it

@LuanVSO
Copy link
Contributor Author

LuanVSO commented Feb 14, 2020

looks like the ci is with some problems

@ryanoasis
Copy link
Owner

Yeah we should fix the CI, maybe I'll look into it..

@ryanoasis ryanoasis merged commit 11bdc7b into ryanoasis:master Feb 22, 2020
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
update cascadia font to its latest release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants