这是indexloc提供的服务，不要输入任何密码
Skip to content

Add Lilex font #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 6, 2020
Merged

Add Lilex font #474

merged 8 commits into from
Sep 6, 2020

Conversation

@adavidzh
Copy link
Contributor

@adavidzh adavidzh commented Apr 28, 2020 •
edited
Loading

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

Any background context you can provide?

Some things that are unclear to me:

  • If/how to add more functionality to src/unpatched-fonts/Lilex.
  • Some of the icons on the table in the main readme.md, esp. since I do not have a Linux or Windows machine to test on and do not know what "EM Size" is.

Screenshots (if appropriate or helpful)

Screenshots would be nice, I agree. 😉

@adavidzh
Copy link
Contributor Author

adavidzh commented Apr 29, 2020

The travis failure is not related to this PR but rather an apt-get issue that also affects #473.

@adavidzh adavidzh marked this pull request as ready for review May 5, 2020 08:03
@kierun
Copy link
Collaborator

kierun commented Jun 2, 2020

@ryanoasis Is there any reasons why we cannot merge this? Not hassling, just curious.

@get-me-power
Copy link
Contributor

get-me-power commented Jun 17, 2020 •
edited
Loading

@kierun @adavidzh @ryanoasis

Please see this PR > #493
shellcheck comes standard with travis. Therefore, there is no need to install it explicitly.

#493's patch can perform CI with better performance.

reference

https://github.com/koalaman/shellcheck/wiki/TravisCI

@ryanoasis
Copy link
Owner

ryanoasis commented Jul 29, 2020

Thanks for the PR and also the follow up. I'll be catching up but hope to make progress fairly soon. 😄

@adavidzh
Copy link
Contributor Author

adavidzh commented Jul 29, 2020 •
edited
Loading

@ryanoasis, since you merged #493, I can update updated my branch to reflect the CI fix.

@ryanoasis
Copy link
Owner

ryanoasis commented Jul 29, 2020

Sure. Great thanks 👍

@adavidzh
Copy link
Contributor Author

adavidzh commented Aug 30, 2020

Any news here?

@ryanoasis ryanoasis merged commit b6bb69e into ryanoasis:master Sep 6, 2020
@Finii Finii mentioned this pull request Aug 20, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adavidzh @kierun @get-me-power @ryanoasis