font-patcher: Correct python module missing message #798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] When the fontforge python bindings are not installed we fail while importing psMat. The message suggests that fontforge itself is not installed - which is not the real reason. One can use the libfontforfge with the python-fontforge without having the GUI program fontforge. Furthermore we link to outdated installation instructions. [how] We already check and report correctly what needs to be done with the fontforge module import. As both modules are often in the same package we should probably report the same message. That message holds correct hints for Debian/Ubuntu. It does not have a link to fontforge, though. [note] Also update Debian package name. Fixes: #725 Reported-by: Aniket Teredesai <a@aniketteredesai.com> Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
When the fontforge python bindings are not installed we fail while
importing
psMat. The message suggests that fontforge itself is notinstalled - which is not the real reason. One can use the
libfontforgewith the
python-fontforgewithout having the GUI programfontforge.Furthermore we link to outdated installation instructions.
[how]
We already check and report correctly what needs to be done with the
fontforge module import. As both modules are often in the same package
we should probably report the same message. That message holds correct
hints for Debian/Ubuntu. It does not have a link to fontforge, though.
[note]
Also update Debian package name.
Fixes: #725
Reported-by: Aniket Teredesai a@aniketteredesai.com
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)