add support for codicons #705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I'll note here that |
Author
|
And the symbol start/end code points were taken from here: https://raw.githubusercontent.com/microsoft/vscode-codicons/main/dist/codicon.csv |
Owner
|
This is great. I'll check it out |
Owner
|
Could you move it into a sub directory and also drop the license file in the same folder? I made a similar recent change here: 9633b4d |
Owner
|
@all-contributors please add @cstrahan for code |
Contributor
|
I've put up a pull request to add @cstrahan! 🎉 |
2 tasks
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
add support for codicons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for codicons (https://github.com/microsoft/vscode-codicons).
@all-contributors please add @cstrahan for code
Requirements / Checklist
./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons./gotta-patch-em-all-font-patcher\!.sh HermitWhat does this Pull Request (PR) do?
Add support for codicons (https://github.com/microsoft/vscode-codicons).
How should this be manually tested?
Perhaps. I have tested this in the gedit text editor as well as within neovim (from gnome-terminal) using the configuration here: https://github.com/onsails/lspkind-nvim
Any background context you can provide?
These are the same glyphs used by VSCode for Language Server icons (e.g. Enum, Member, Class, etc).
What are the relevant tickets (if any)?
Closes #620
Screenshots (if appropriate or helpful)