ComicShanns: Fix carons #1546
Merged
ComicShanns: Fix carons #1546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] The carons are all upside down. The dcaron and tcaron should use an 'apothrophe'. [how] The simplify the fixing of all carons we take the excellent fork ofu Rodrigo Batista de Moraes that (re?)creates the letters with caron from references. Just manually flip the caron and all combined glyphs will be fixed. Create a combining-comma-above-right from the ordinary comma. Reference that for dcaron and tcaron. Rerun `make-bold` which creates the two otf files. Fixes: #1492 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
98bcb3a to
77bdab3
Compare
This was referenced Mar 18, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
The carons are all upside down.
The dcaron and tcaron should use an 'apothrophe'.
[how]
The simplify the fixing of all carons we take the excellent fork ofu Rodrigo Batista de Moraes that (re?)creates the letters with caron from references.
Just manually flip the caron and all combined glyphs will be fixed.
Create a combining-comma-above-right from the ordinary comma.
Reference that for dcaron and tcaron.
Rerun
make-boldwhich creates the two otf files.Fixes: #1492
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)