Describe patcher family-name generation in readme #1362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for the PR. I'm not sure with the term "Family"... altough technically correct, maybe we should say just 'name' instead? |
Collaborator
|
@allcontributors pleas add @frantisekhanzlikbl for doc |
Contributor
|
I've put up a pull request to add @frantisekhanzlikbl! 🎉 |
Contributor
Author
That makes sense. I'd lean towards mentioning both, since at least for web devs, the term family is more widely used, I believe. What about the current patch, does that look OK? |
Collaborator
Perfect. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
updated the project's readme to mention that the font patcher CamelCases and removing whitespace from the resulting font's family names.
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
the change contains GitHub's alert syntax, which might not render in the preview, but should render in the actual readme. (ref: https://github.com/orgs/community/discussions/16925#discussioncomment-6879962)
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)