这是indexloc提供的服务，不要输入任何密码
Skip to content

typo in title #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

typo in title #131

wants to merge 1 commit into from

Conversation

@ghost
Copy link

@ghost ghost commented Feb 17, 2017

Description

Please explain the changes you made here.

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

@ryanoasis
Copy link
Owner

ryanoasis commented Feb 19, 2017

Hey thanks for the PR but actually it is not a typo and is done on purpose to comply with licensing. Particularly SIL Open Font License (OFL).

Some fonts have parts of their name 'reserved', Fira for example: https://github.com/ryanoasis/nerd-fonts/blob/master/src/unpatched-fonts/FiraCode/LICENSE.txt
In particular this part:

No Modified Version of the Font Software may use the Reserved Font
Name(s) unless explicit written permission is granted by the corresponding
Copyright Holder. This restriction only applies to the primary font name as
presented to the users.

This is probably not very clear in the readme and is not explicitly mentioned in the FAQ either.

Feel free to submit a PR that might clarify the name changes or feel free to contribute the FAQ 😄

@ryanoasis ryanoasis closed this Feb 19, 2017
This was referenced Mar 2, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ryanoasis