FontnameParser: Fix fsSelection for --has-no-italic #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Fixed: Thanks again @liaoya for reporting! |
Collaborator
Author
|
Affected: $ grep -r --include '*.cfg' '.--has-no' .
./src/unpatched-fonts/DejaVuSansMono/config.cfg:config_patch_flags="--has-no-italic"
./src/unpatched-fonts/BitstreamVeraSansMono/config.cfg:config_patch_flags="--has-no-italic" |
[why] For fonts that have no Italic but an Oblique - i.e. when Oblique shall replace the Italic role in RIBBI font grouping (classic group of 4) - that grouping fails. This affects DejaVu on Putty. [how] For RIBBI grouping only the classic bits are considered. That means that for fonts that have Oblique instead of Italic (and not additionally) we need to set the ITALIC bit and the OBLIQUE bit. This has been overlooked. Cite from the specs: > This bit, unlike the ITALIC bit (bit 0), is not related to style-linking > in applications that assume a four-member font-family model comprised > of regular, italic, bold and bold italic. It may be set or unset > independently of the ITALIC bit. In most cases, if OBLIQUE is set, then > ITALIC will also be set, though this is not required. [note] Also increase font-patcher version. Fixes: #1249 Reported-by: Huifeng Shen <liaoya@gmail.com> Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
73a10c3 to
6ce70f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
For fonts that have no Italic but an Oblique - i.e. when Oblique shall replace the Italic role in RIBBI font grouping (classic group of 4) - that grouping fails.
This affects DejaVu on Putty.
[how]
For RIBBI grouping only the classic bits are considered. That means that for fonts that have Oblique instead of Italic (and not additionally) we need to set the ITALIC bit and the OBLIQUE bit. This has been overlooked.
Cite from the specs:
Fixes: #1249
Reported-by: Huifeng Shen liaoya@gmail.com
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Create new set of DejaVu, install NFM on Windows, start putty.
Any background context you can provide?
https://learn.microsoft.com/en-us/typography/opentype/spec/os2#fsselection
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)