Bugfix logging on AppImage #1208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] When font-patcher is on a read only filesystem the pacher can not run. This is for example the case when fontforge is a AppImage. [how] Try if the logfile can be written, and if not disable logging into a file. Reported-by: Bliss X. Xu <blissLove8@gmail.com> Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] Maybe it is not a good idea to always create the log file, as most people will never look into it. The main reason for it was the gotta-patch-em script so that one can check after lots of runs what the details were. [how] Introduce parameter to --debug option. 0 = no debug output 1 = log to file only (previously always selected) 2 = log to stdout only 3 = log to file and stdout (previous default for --debug) Just specifying --default equals now --debug 2. The gotta-patch-em runs now with --debug 1. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
…pimage Bugfix logging on AppImage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
font-patcheralways logs the debug messages in a file.That fails when
fontforgeis an AppImage (and maybe when we are a docker image?)This PR drops that feature. Logging to file has to be explicitly requested with a parameter to the
--debugoption.Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Reported on Gitter by @loveFluffy - Thank you for the report!
Screenshots (if appropriate or helpful)