Bugfix/fix octa scale #1199
Merged
Bugfix/fix octa scale #1199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] With the Octicons update some codepoint contents changed. Also some symbols scale still wrong. [how] Check fonts and add / drop entries. Use GlyphsToScale+ to correct position of Github text icon. Fixes: #1198 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] The scale glyph is not the biggest glyph; the bell-slash is a little bit wider than the design cell... [how] Switch to modern ScaleGroups. These determine the virtual combined bounding box of all glyphs in the group and scale them 'as one'. Also add some more groups. Also correct wrong code of one small stuff. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Collaborator
Author
|
@allcontributors add @jimeh for bug |
Contributor
|
I've put up a pull request to add @jimeh! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1198
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)