Fix weather icon scale and shift #1109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1ea333 to
80e2f2d
Compare
[why] The scaling of the clouds is not identical but depends on the actual glyph bounding box. But the clouds should all have the same scaling to be 'interchangeable' [how] Put all clouds in a ScaleGroup. Also add missing Celsius degrees glyph to other degree glyphs group. Fixes: #1107 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] When a ScaleGroup's combinded bounding box is wider than the target font cell the actual X position of a glyph in the group depends on it's own bonding box and not of the combinded bounding box. When doing center or right alignment. [how] 'Overwide' ScaleGroup glyphs are correctly placed and shifted in position, but that would mean a negative left side bearing (i.e. glyph extends to the left into previous 'cell'). We do not want that and it is later corrected for all glyphs. But that is done on an individual glyph level and it is just left aligned for its concrete bounding box (i.e. left side bearing is set to zero). The dilemma here is that you can not really center a (combinded) glyph within a cell, when * the cell is smaller than the glyph * a left bearing is not allowd So we change the algorithm here that 'center' and 'right' alignment mean: * Center the glyph in the target font cell * But if that would create a left side 'overhang' (bearing) just left align (move it as far left as possible without creating a negative bearing) The only glyphs affected by this change are the very wide weather icons, and here escpecially the moon phases F096 and following (target codepoints E38E ..). Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
80e2f2d to
1dd26a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The clouds in the weather icons are all scaled individually.
This makes it hard to exchange one for the other when the weather changes.
Also a problem are the moon phases, all the increasing phases are shifted a bit to the left?!
This PR fixes both issues with one commit each.
Fixes: #1107
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)