Bugfix Panose on "Nerd Font" variants #1099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] query_monospace is newer. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] Some fonts have invalid (or unset) Panose flags. When we create a "Nerd Font Mono" font the Panose proportion is set to 'monospace'. This make the font selectable in certain applications that need monospaced fonts. After #764 the "Nerd Font" variant shall (again) be detected as monospaced font, but the glyphs have a big right side bearing (hang into the next 'cell'). So we need to set the Panose bits there also. [how] We already have a check if the font is propably monospaced, independent from Panose. This is used to prevent --mono patching on originally proportional fonts. If we find out with that check that the font is (most probably) monospaced we also set the appropriate bits in Panose; unless Panose has valid values that contradict that change. Fixes: #1098 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Collaborator
Author
All Panose related messagesRunning on all fonts in HermitBold and light not monospaced? iA WriterPanose only partially filled OpenDyslexicPanose only partially filled MononokiPanose empty ProggyCleanPanose only partially filled RobotoMonoPanose empty ProFontPanose only partially filled DaddyTimeMonoPanose only partially filled LektonPanose proportion unset / strange MonofurOnly Italic has unset proportion?! FiraCodePanose empty CascadiaCodePanose empty (issue raised at their repo) GohuOne style has different proportion in Panose InconsolataPanose empty LilexPanose empty VictorMonoPanose only partially set OverpassPanose only partially set |
Finii
added a commit
that referenced
this pull request
Feb 2, 2023
[why] Forgot to push these changes to the PR #1099. They are just 'more output'. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
added a commit
to b-/nerd-fonts
that referenced
this pull request
Feb 17, 2023
[why] Forgot to push these changes to the PR ryanoasis#1099. They are just 'more output'. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
…ndard-variant Bugfix Panose on "Nerd Font" variants
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
[why] Forgot to push these changes to the PR ryanoasis#1099. They are just 'more output'. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[why]
Some fonts have invalid (or unset) Panose flags. When we create a
Nerd Font Monofont the Panose proportion is set tomonospace. Thismake the font selectable in certain applications that need monospaced
fonts.
After #764 the
Nerd Fontvariant (withoutMono) shall (again) be detected asmonospaced font, but the glyphs have a big right side bearing (hang into
the next 'cell'). So we need to set the Panose bits there also.
[how]
We already have a check if the font is probably monospaced, independent
from Panose. This is used to prevent
--monopatching on originallyproportional fonts.
If we find out with that check that the font is (most probably)
monospaced we also set the appropriate bits in Panose; unless Panose has
valid values that contradict that change.
Fixes: #1098
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Install
CaskaydiaCove Nerd Font Complete.ttfon Windows and try to select it inWindows Terminal(without 'all fonts').Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)