font-patcher: Fix unexpected 'Book' SubFamily #1047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] Sometimes we set an empty string as SubFamily name. That ends up as 'Book' which is unexpected. [how] The translation from empty to "Book" is done by Fontforge, at least with version 20220308. Make sure we always have a SubFamily, and if we don't that must be a 'Regular'. [note] This was only a problem with the old naming engine. --makegroups got this right always. Fixes: #1046 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
91cbffd to
15c9597
Compare
Collaborator
Author
It's a bug, it's fixed with this PR. |
Collaborator
Author
|
Currently CI has problems, Azure ... |
Collaborator
Author
|
Tests ran successfully on https://github.com/ryanoasis/nerd-fonts/actions/runs/3909272670 Merging. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
Sometimes we set an empty string as SubFamily name. That ends up as 'Book' which is unexpected.
[how]
The translation from empty to "Book" is done by Fontforge, at least with version 20220308.
Make sure we always have a SubFamily, and if we don't that must be a 'Regular'.
[note]
This was only a problem with the old naming engine.
--makegroupsgot this right always.Fixes: #1046
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
#780 (comment)
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)