font-patcher: Fix some Nerd Font Mono too wide #1045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] The 'monospace' width is determined by examining all the 'normal' glyphs and taking the widest one. 'Normal' means 0x00-0x17f: the Latin Extended-A range. Unfortunately Overpass (Mono) has wide-as-two-letters IJ and ij ligatures. [how] Exclude a small sub-range from the 'find the widest glyph' that contain these ligatures. Yes they will kind of break, but what can we do if we want to create a strictly monospaced font? [note] Related commit fbe07b8 Fix Noto too wide Related: #1043 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Collaborator
Author
|
Searching systematically for more potentially problematic fonts... These need a more detailed look at
[1] These fonts look bad, probably because they are already Poweline patched and THAT patching went wrong. At least we introduce no new issues. Codes (hex)
|
[why] The 'monospace' width is determined by examining all the 'normal' glyphs and taking the widest one. 'Normal' means 0x00-0x17f: the Latin Extended-A range. Unfortunately some fonts that claim to be monospaced still have some glyphs that are wider than the others. [how] Exclude a small group of glyphs from the 'find the widest glyph'. The list is specifically targetted at the fonts we patch, see PR #1045. Most of these glyphs are either visually small and it is unclear why they are too wide (like double-quotes), or they are from the real extended set, notably all the Eth (D with a slash) and other added-slash or added-caron glyphs. In ignoring them we might 'break' these specific glyphs for the people who use them (like: they extend out of the cell into the next), but that is the only way to keep the 'monospaced promise' without redesigning the actual font. But without these exceptions we have Nerd Font Mono fonts that increase the cell width so that 'normal text' is rendered almost unreadable. So this is an improvement for most users; and I see no way so solve these font issues for all users (without redesigning the font itself ;). Also add a 'warning' if a (still) problematic font is to be patched. As reminder for self-patcher or when we add fonts here. [note] Related commit fbe07b8 Fix Noto too wide 2945cec Fix Overpass Mono too wide Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
This was referenced Jan 28, 2023
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
[why] The 'monospace' width is determined by examining all the 'normal' glyphs and taking the widest one. 'Normal' means 0x00-0x17f: the Latin Extended-A range. Unfortunately some fonts that claim to be monospaced still have some glyphs that are wider than the others. [how] Exclude a small group of glyphs from the 'find the widest glyph'. The list is specifically targetted at the fonts we patch, see PR ryanoasis#1045. Most of these glyphs are either visually small and it is unclear why they are too wide (like double-quotes), or they are from the real extended set, notably all the Eth (D with a slash) and other added-slash or added-caron glyphs. In ignoring them we might 'break' these specific glyphs for the people who use them (like: they extend out of the cell into the next), but that is the only way to keep the 'monospaced promise' without redesigning the actual font. But without these exceptions we have Nerd Font Mono fonts that increase the cell width so that 'normal text' is rendered almost unreadable. So this is an improvement for most users; and I see no way so solve these font issues for all users (without redesigning the font itself ;). Also add a 'warning' if a (still) problematic font is to be patched. As reminder for self-patcher or when we add fonts here. [note] Related commit fbe07b8 Fix Noto too wide 2945cec Fix Overpass Mono too wide Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
The 'monospace' width is determined by examining all the 'normal' glyphs and taking the widest one.
'Normal' means
0x00-0x17f: the Latin Extended-A range.Unfortunately Overpass (Mono) has wide-as-two-letters
IJandijligatures.[how]
Exclude a small sub-range from the 'find the widest glyph' that contain these ligatures. Yes they will kind of break, but what can we do if we want to create a strictly monospaced font?
[note]
Related commit
fbe07b8 Fix Noto too wide
Related: #1043
Requirements / Checklist
What does this Pull Request (PR) do?
Exclude IJ and ij ligatures from the width calculation (for NFM), as they are too wide in the supposed to be
monospacedfontOverpass Mono.How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)