这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@nataliakeniganti
Copy link

Description

Updates the GitLab icon as per https://about.gitlab.com/press/press-kit/.

Requirements / Checklist

  • Read the Contributing Guidelines
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.
  • If this contains a font/glyph add its origin as background info below (e.g. URL)
  • Verified the license of any newly added font, glyph, or glyph set. License is: CC-BY-SA-4.0,3.0,2.5,2.0,1.0 license

@Finii
Copy link
Collaborator

Finii commented Jan 19, 2025

Thanks for the PR!

Technically the svg should be just one path d, while the svg here is colored. The font is monochrome, and the automatic conversion can and does fail (i.e. has suboptimal results) - thus the conversion to one path (without outline width, transforms, or clip paths).

Anyhow, I can fix that easily.

One problem I have with this is that you replace nf-seti-gitlab, which is an icon from the Seti set [1]. That would mean the original Seti and what we use differ. In fact the Seti set would have to be updated (first). Otoh I am a bit confused right now where the current icon comes from exactly. We updated Seti with

but it seems there was a problem and later fixes and I need to untangle that first.

Probably the (your) icon needs to be added with a new codepoint as nf-custom-gitlab.

Let me check that again when I'm on my real machine tomorrow or so.

[1] https://github.com/jesseweed/seti-ui

Edit: Of course I meant custom-gitLAB and not custom-gitHUB

@nataliakeniganti
Copy link
Author

Thanks for the PR!

Technically the svg should be just one path d, while the svg here is colored. The font is monochrome, and the automatic conversion can and does fail (i.e. has suboptimal results) - thus the conversion to one path (without outline width, transforms, or clip paths).

Anyhow, I can fix that easily.

One problem I have with this is that you replace nf-seti-gitlab, which is an icon from the Seti set [1]. That would mean the original Seti and what we use differ. In fact the Seti set would have to be updated (first). Otoh I am a bit confused right now where the current icon comes from exactly. We updated Seti with

but it seems there was a problem and later fixes and I need to untangle that first.

Probably the (your) icon needs to be added with a new codepoint as nf-custom-github.

Let me check that again when I'm on my real machine tomorrow or so.

[1] https://github.com/jesseweed/seti-ui

Turn into monochrome

@Finii
Copy link
Collaborator

Finii commented Jan 19, 2025 via email

@nataliakeniganti nataliakeniganti deleted the update-gitlab-icon branch January 19, 2025 19:16
@Finii
Copy link
Collaborator

Finii commented Jan 19, 2025

Screenshot 2025-01-19 at 21 46 13

Ok, whatever, the newer round form is available under other codepoints. (nf-dev-gitlab and nf-fa-gitlab)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants