这是indexloc提供的服务，不要输入任何密码
Skip to content

Update CSS icon #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 7, 2025
Merged

Update CSS icon #1762

merged 5 commits into from
Jan 7, 2025

Conversation

@skoch13
Copy link
Contributor

@skoch13 skoch13 commented Dec 18, 2024 •
edited
Loading

Description

Updates the CSS icon as per https://github.com/CSS-Next/logo.css.

Generated small version for improved readability as icon as suggested here.

Requirements / Checklist

  • Read the Contributing Guidelines
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.
  • If this contains a font/glyph add its origin as background info below (e.g. URL)
  • Verified the license of any newly added font, glyph, or glyph set. License is: CC0-1.0 license

realguse
realguse approved these changes Dec 21, 2024
View reviewed changes
Copy link
Contributor

@realguse realguse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Finii
Copy link
Collaborator

Finii commented Dec 22, 2024

Thanks for the PR!

I am just wondering, because the old icon is so unspecific, if people use it to get a fat # unrelated to css. Like a This is a root shell, because root at least in former times had a # instead of a $ to warn users 🤔 But then, maybe that concept is too old.

So in principle maybe it is better to add the new css logo instead of replacing the old seti one?

Screenshot 2024-12-22 at 11 09 01

Some random mention of the use of # for root shells:

Screenshot 2024-12-22 at 11 14 38

@Finii
Copy link
Collaborator

Finii commented Dec 22, 2024

Note to self: The svg needs some manual cleanup
(Don't worry with that, I will just do it before pull)

Screenshot 2024-12-22 at 11 24 10

@skoch13
Copy link
Contributor Author

skoch13 commented Dec 22, 2024

@Finii thank you for your suggestions!
I’m wondering if those who know what hashtag stands for in say bash will ever use css icon to represent it 😀

That being said I’m 100% positive not breaking existing workflows. Will placing it in the very same folder with the css_new.svg name address this?

@skoch13
Copy link
Contributor Author

skoch13 commented Dec 22, 2024

The svg needs some manual cleanup

I was thinking about this myself, but decided not to touch it prematurely. Thank you

@skoch13
Copy link
Contributor Author

skoch13 commented Jan 2, 2025

@Finii please let me know how I should proceed with this PR

@skoch13 skoch13 force-pushed the sk/update-css-icon branch from cb7b429 to 0c34517 Compare January 7, 2025 11:52
@skoch13
Copy link
Contributor Author

skoch13 commented Jan 7, 2025

@Finii I've just updated this PR while adding the new icon as a separate file

@Finii
Copy link
Collaborator

Finii commented Jan 7, 2025 •
edited
Loading

I will remove the transform which sometimes confuses fontforge's svg import, and do other needed stuff, some pushes imminent

image

Finii added 2 commits January 7, 2025 13:14
@Finii
svgs: css: Simplify to path
0b0301a 
[why]
Fontforge's cvs import sometimes struggles (hard) on transforms.

[how]
Apply the transform before saving. It's not that we want to edit it
anyhow, so no reason to keep that abstraction.

Also remove some meta-information.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
svgs: Add new css icon to custom set
565f4e7 
We keep the Seti css logo, as the abstract hash tag is prone to 'misuse'
for other purposes and an update of the logo would break it. Anyhow CSS
shield is the current logo before the newly added one, and anyone who
used the Seti css logo (i.e. hash tag) would probably mean something
entirely different.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Copy link
Collaborator

Finii commented Jan 7, 2025

image

@Finii
Copy link
Collaborator

Finii commented Jan 7, 2025 •
edited
Loading

🤔 Something wrong with the CI, no action triggered?!

Edit: ... now running:

image

Finii and others added 2 commits January 7, 2025 13:40
@Finii Finii merged commit 06fff30 into ryanoasis:master Jan 7, 2025
@Finii
Copy link
Collaborator

Finii commented Jan 7, 2025

@allcontributors please add @skoch13 for code

@allcontributors allcontributors bot mentioned this pull request Jan 7, 2025
Merged
@allcontributors
Copy link
Contributor

allcontributors bot commented Jan 7, 2025

@Finii

I've put up a pull request to add @skoch13! 🎉

@Finii
Copy link
Collaborator

Finii commented Jan 7, 2025

Thank you again :-)

A new docker & zip will come when I fixed the other icons (== soon).

@Finii
Copy link
Collaborator

Finii commented Jan 7, 2025

@allcontributors please add @realguse for review

@allcontributors allcontributors bot mentioned this pull request Jan 7, 2025
Merged
@allcontributors
Copy link
Contributor

allcontributors bot commented Jan 7, 2025

@Finii

I've put up a pull request to add @realguse! 🎉

@skoch13
Copy link
Contributor Author

skoch13 commented Jan 14, 2025

@Finii I'm sorry in advance for pinging, but just wanted to check on the following:

A new docker & zip will come when I fixed the other icons (== soon)

Will there be a new release arranged for these changes?

@Finii
Copy link
Collaborator

Finii commented Jan 14, 2025

Last release was ... *paper rustling* ... mid November.

I'd guess a minimal distance of 1/4 year is good which would mean mid February.

And then I would like to get feedback form this (change), someone of the Issue commenters or whoever owns that font should test it:

Just added a new milestone for that release: https://github.com/ryanoasis/nerd-fonts/milestone/32

@Finii Finii added this to the v3.4.0 milestone Jan 14, 2025
@Finii
Copy link
Collaborator

Finii commented Jan 14, 2025

Well, the zip and the docker are already ... released.

So if you just need it for yourself you should be able to self-patch.

https://hub.docker.com/r/nerdfonts/patcher

image

https://github.com/ryanoasis/nerd-fonts/blob/master/FontPatcher.zip

image

@skoch13
Copy link
Contributor Author

skoch13 commented Jan 14, 2025

@Finii I'm good with the waiting. thank you once again!

@skoch13 skoch13 deleted the sk/update-css-icon branch January 15, 2025 09:36
@skoch13 skoch13 mentioned this pull request May 5, 2025
Closed
2 tasks
@typedrat typedrat mentioned this pull request May 22, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@realguse realguse realguse approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

❲+❳ add glyph to core set

Projects

None yet

Milestone

v3.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@skoch13 @Finii @realguse