这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@my4ng
Copy link
Contributor

@my4ng my4ng commented May 1, 2024

Description

Update 0xProto from 1.603 to version 2.201. Check the changelog for more details.

Requirements / Checklist

  • Read the Contributing Guidelines
  • Verified the license of any newly added font, glyph, or glyph set. License is: OFL-1.1 license (NO CHANGE)

What does this Pull Request (PR) do?

Update 0xProto to version 2.201.

How should this be manually tested?

fontforge --script ./font-patcher src/unpatched-fonts/0xProto/Regular/0xProto-Regular.ttf --complete --debug 2
fontforge --script ./font-patcher src/unpatched-fonts/0xProto/Italic/0xProto-Bold.ttf --complete --debug 2
fontforge --script ./font-patcher src/unpatched-fonts/0xProto/Italic/0xProto-Italic.ttf --complete --debug 2

@Finii
Copy link
Collaborator

Finii commented May 2, 2024

Thanks for the nice PR!

One question: Why did you put the font file into sub-directories? Is there anything in the documentation that suggests it? I have seen this now with multiple PRs.

"is a programming font focused on source code legibility."

Well, which font does not? That slogan is even lamer than before ;-) But that seems to be the official 'subtitle'.
Otoh we could add something meaningful instead, if you have any idea why it is great?


Edit:

Hmm, you ticked Read the Contributing Guidelines 🤔
Is that easy to misunderstand? I would like to improve it if needed. 🤔

@Finii Finii added this to the v3.3.0 milestone May 2, 2024
@my4ng
Copy link
Contributor Author

my4ng commented May 3, 2024

One question: Why did you put the font file into sub-directories? Is there anything in the documentation that suggests it? I have seen this now with multiple PRs.

I thought this is required in the Contributing Guidelines:

Make sure to update the correct subfolders for each font style (e.g. src/unpatched-fonts/xyz/bold/{BOLD FONT FILES HERE}), if applicable

Since 0xProto has released a new dedicated italic version, I thought it makes sense to put them in Regular and Italic folders separately.

Otoh we could add something meaningful instead, if you have any idea why it is great?

I think the features headings in the README are good pointers, especially clear differentiation and ligatures that do not deform.

@Finii
Copy link
Collaborator

Finii commented May 3, 2024

Thanks for the feedback!

if applicable

Ah I see.

are good pointers

What do you think about .... lets see

... is a programming font with clear differentiation and ligatures that do not deform

:-)


Marking this as ready, but I will hold it back until release time, and update to whatever version is current then (maybe 2.0.1 ;)

If you like maybe you can undo the sub-directory change and put both fonts into one directory. But I can change that later if you prefer.

@Finii Finii added the Ready ⛱ Ready to merge but waiting to be merged near a release label May 3, 2024
@Finii
Copy link
Collaborator

Finii commented May 3, 2024

@allcontributors please add @my4ng for code

@Finii
Copy link
Collaborator

Finii commented May 3, 2024

💭 allcontributors has some problem? I will try again later...

@allcontributors
Copy link
Contributor

@Finii

We had trouble processing your request. Please try again later.

@my4ng
Copy link
Contributor Author

my4ng commented May 3, 2024

If you like maybe you can undo the sub-directory change and put both fonts into one directory. But I can change that later if you prefer.

Yeah I saw a couple other unpatched fonts were doing that, so I just followed suit 😅. Anyway, I have corrected that but I left the one-line description as it was.

@Finii
Copy link
Collaborator

Finii commented May 3, 2024

@allcontributors please add @my4ng for code

@allcontributors
Copy link
Contributor

@Finii

@my4ng already contributed before to code

@Finii Finii mentioned this pull request May 3, 2024
4 tasks
@Finii Finii mentioned this pull request May 10, 2024
3 tasks
@my4ng
Copy link
Contributor Author

my4ng commented May 18, 2024

I have updated 0xProto to 2.001

@my4ng my4ng changed the title Update 0xProto to 2.000 Update 0xProto to 2.001 May 18, 2024
@my4ng my4ng changed the title Update 0xProto to 2.001 Update 0xProto to 2.100 Jun 5, 2024
@matype matype mentioned this pull request Aug 2, 2024
@my4ng my4ng changed the title Update 0xProto to 2.100 Update 0xProto to 2.200 Sep 2, 2024
@Finii
Copy link
Collaborator

Finii commented Sep 2, 2024

Thanks @my4ng 💚

@Finii
Copy link
Collaborator

Finii commented Sep 2, 2024

💭 Need to start work for the new Release, milestone is 9/24. At the moment too many other things on my personal agenda

Edit: And a new Nerd Font release is usually started with a new Font Logos release first 😬 so we can use all icons that have been added meanwhilst.

@my4ng my4ng changed the title Update 0xProto to 2.200 Update 0xProto to 2.201 Sep 8, 2024
@my4ng
Copy link
Contributor Author

my4ng commented Oct 11, 2024

@Finii Is there a new date for the release? No rush if you still have other stuff on your hands.

@Finii
Copy link
Collaborator

Finii commented Oct 17, 2024

@my4ng

😭

Feel free to keep pinging me, I just struggle to find a longer time slot; the short times I do find currently just do not suffice to get the 'flow running' :-( I hope for some time in the coming weekend, but that already seems to be filled up by stuff 😬

I know how frustrating that is for all the ppl waiting for the release, from when I was the person waiting for the maintainer to 'just trigger a release, what can be so difficult'.

One problem is of course #1691, if you want you could review the icon sizes etc ;-D

@Finii
Copy link
Collaborator

Finii commented Nov 17, 2024

Thank you again!

@Finii Finii merged commit bfdaf70 into ryanoasis:master Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

❲Aa❳ update font version bump Ready ⛱ Ready to merge but waiting to be merged near a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants