这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix alignment for some glyhs in propo #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 23, 2025
Merged

Fix alignment for some glyhs in propo #1852

merged 3 commits into from
Apr 23, 2025

Conversation

@Finii
Copy link
Collaborator

@Finii Finii commented Apr 23, 2025

Description

[why]
When the source glyph set is in a monospace group the proportional
scaling creates wrong advance widths and/or alignment.

Note that there are only very few monospace groups (i.e. 2).

[how]
Determine the 'cell' width, which can be one of three values depending
on mode. Use that width whereever a cell width is needed instead of the
fontwide-cellwidth (which might be wrong in proportional variants).

Requirements / Checklist

  • Read the Contributing Guidelines
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.
    Issue number where discussion took place: #xxx
  • If this contains a font/glyph add its origin as background info below (e.g. URL)
  • Verified the license of any newly added font, glyph, or glyph set. License is: xxx

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

These are all affected in the symbols only font (usually too far right, outside 'cell')

image

@Finii
Copy link
Collaborator Author

Finii commented Apr 23, 2025

Here the new alignment (green) is wrong :-/

image

@Finii Finii added this to the v3.4.0 milestone Apr 23, 2025
@Finii Finii force-pushed the bugfix/monospace-groups branch 2 times, most recently from 23f4f4c to 53f8b92 Compare April 23, 2025 11:37
Finii added 3 commits April 23, 2025 14:27
@Finii
font-patcher: Use modern scale group for brackets
0202a30 
[why]
The old ScaleGlyph group can not align the glyphs correctly, because it
has a lot assumptions that just do not hold. Especially we want the
monospace flag being set for the group.

Fixes: #1822

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
font-patcher: Whitespace changes
9cdd330 
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
font-patcher: Fix NFP scaling for pa on monospaced set
52446fd 
[why]
When we create a Nerd Font Propo the 'xy' streched glyphs should fill
the whole target cell (vertically and horizontally), but when 'pa'
scaling is selected the advance of the original glyph should be
preserved.

Fixes: #1822
Fixes: #1847

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii force-pushed the bugfix/monospace-groups branch from 53f8b92 to 52446fd Compare April 23, 2025 12:28
@Finii
Copy link
Collaborator Author

Finii commented Apr 23, 2025

Also changes a lot of cod icons, centers them in Propo

image

-Differences...
  +Names
  -Outline Glyphs
    -Glyph Differences
      +Glyph “uni276C” differs
      +Glyph “uni276D” differs
      +Glyph “uni276E” differs
      +Glyph “uni276F” differs
      +Glyph “uni2770” differs
      +Glyph “uni2771” differs
       Spline mismatch in glyph “cod-lightbulb”
       Spline mismatch in glyph “cod-reply”
       Spline mismatch in glyph “cod-arrow_both”
       Spline mismatch in glyph “cod-arrow_down”
       Spline mismatch in glyph “cod-arrow_left”
       Spline mismatch in glyph “cod-arrow_right”
       Spline mismatch in glyph “cod-arrow_small_down”
       Spline mismatch in glyph “cod-arrow_small_left”
       Spline mismatch in glyph “cod-arrow_small_right”
       Spline mismatch in glyph “cod-arrow_small_up”
       Spline mismatch in glyph “cod-arrow_up”
       Spline mismatch in glyph “cod-bell”
       Spline mismatch in glyph “cod-chevron_down”
       Spline mismatch in glyph “cod-chevron_left”
       Spline mismatch in glyph “cod-chevron_right”
       Spline mismatch in glyph “cod-chevron_up”
       Spline mismatch in glyph “cod-debug_step_into”
       Spline mismatch in glyph “cod-debug_step_out”
       Spline mismatch in glyph “cod-debug_step_over”
       Spline mismatch in glyph “cod-lightbulb_autofix”
       Spline mismatch in glyph “cod-request_changes”
       Spline mismatch in glyph “cod-triangle_down”
       Spline mismatch in glyph “cod-triangle_left”
       Spline mismatch in glyph “cod-triangle_right”
       Spline mismatch in glyph “cod-triangle_up”
       Spline mismatch in glyph “cod-debug_stackframe_active”
       Spline mismatch in glyph “cod-circle_small_filled”
       Spline mismatch in glyph “cod-debug_stackframe”
       Spline mismatch in glyph “cod-bell_dot”
       Spline mismatch in glyph “cod-arrow_swap”
       Spline mismatch in glyph “cod-compass”
       Spline mismatch in glyph “cod-compass_dot”
       Spline mismatch in glyph “cod-compass_active”
       Spline mismatch in glyph “cod-circle_small”
       Spline mismatch in glyph “cod-bell_slash”
       Spline mismatch in glyph “cod-bell_slash_dot”
       Spline mismatch in glyph “cod-git_pull_request_go_to_changes”
       Spline mismatch in glyph “cod-git_pull_request_new_changes”
       Spline mismatch in glyph “uniEE06”
       Spline mismatch in glyph “uniEE07”
       Spline mismatch in glyph “uniEE08”
       Spline mismatch in glyph “uniEE09”
       Spline mismatch in glyph “uniEE0A”
       Spline mismatch in glyph “uniEE0B”
       Spline mismatch in glyph “fa-person_dress”
       Spline mismatch in glyph “fa-person”
       Spline mismatch in glyph “oct-move_to_bottom”
       Spline mismatch in glyph “oct-move_to_end”
       Spline mismatch in glyph “oct-move_to_start”
       Spline mismatch in glyph “oct-move_to_top”

@Finii
Copy link
Collaborator Author

Finii commented Apr 23, 2025

The COD fixes are also real, here the Nerd Font Propo font before the PR, note that some glyphs are centered, while others are kind of left aligned, but the advance width is everywhere 1000, so ....

image

@Finii
Copy link
Collaborator Author

Finii commented Apr 23, 2025

In the Symbols Only font a lot of the weather icons are fixed

image

For some reason they were too far to the right

image

Old: grey, new: green

@Finii Finii merged commit c8157b4 into master Apr 23, 2025
4 checks passed
@Finii Finii deleted the bugfix/monospace-groups branch April 23, 2025 13:37
@typedrat typedrat mentioned this pull request May 22, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

❲⌖❳glyph positioning ❲⚖❳glyph sizing

Projects

None yet

Milestone

v3.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Finii