这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@KDhruv3
Copy link

@KDhruv3 KDhruv3 commented Nov 4, 2025

Closes #16019

BoxyUwU and others added 30 commits October 7, 2025 23:02
This should address
rust-lang#13099 for the let_unit
test.

changelog: [manual_assert]: Updated manual_assert to use
multipart_suggestions where appropriate
Some methods lints were handled in the `methods` module outside the
`check_methods()` function.
Some methods lints were handled in the `methods` module outside the
`check_methods()` function.

changelog: none
it's now just the first arm
changelog: [`unnecessary_option_map_or_else`]: Added lint
unnecessary_option_map_or_else. As suggested in the issue description,
the implementation takes as reference the issue
rust-lang#7328. The tests for lints `option_if_let_else` and
`or_fun_call` needed to be adjusted to comply with new lint.
fixes rust-lang#14588
I'll still take care of my currently-assigned reviews.
Edit: Sorry Philipp, I forgot to r? ghost

changelog:none
…-lang#15849)

changelog: [`expl_impl_clone_on_copy`]: honor `allow`/`expect`
attributes on both the type declaration and the `impl`

Fixes rust-lang#15842

r? @blyxyas
Closes rust-lang#15555

changelog: [`use_self`]: Check structs and enums
ada4a and others added 17 commits October 31, 2025 21:21
misc stuff I found while working on rust-lang#15343. Not
sure about the `P` part, but the rest should be fine

changelog: none
Needed to split the lint crate.

Both the method and loop versions of the lint should also behave the
same now.

changelog: None
Closes rust-lang#15968

changelog: [`replace_box`] fix FP when the box is moved

r? samueltardieu As you wish

<!-- TRIAGEBOT_START -->

<!-- TRIAGEBOT_SUMMARY_START -->

### Summary Notes

-
[Beta-nomination](rust-lang#15984 (comment))
by [samueltardieu](https://github.com/samueltardieu)

*Managed by `@rustbot`—see
[help](https://forge.rust-lang.org/triagebot/note.html) for details*

<!-- TRIAGEBOT_SUMMARY_END -->
<!-- TRIAGEBOT_END -->
…-lang#16006)

Fixes rust-lang#15987

changelog: [`let_and_return`]: disallow _any_ text between let and
return
The "bad" example in the `missing_transmute_annotations` example didn't
actually trigger the lint and so wasn't a "bad" example. This PR
replaces it with an actual "bad" example.

It was discussed on zulip
[here](https://rust-lang.zulipchat.com/#narrow/channel/257328-clippy/topic/missing_transmute_annotations/near/547657390).

changelog: Fix `missing_transmute_annotations` example

r? @Centri3
@rustbot
Copy link
Collaborator

rustbot commented Nov 4, 2025

Some changes occurred in clippy_lints/src/doc

cc @notriddle

@rustbot rustbot added needs-fcp S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Nov 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 4, 2025

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Nov 4, 2025

⚠️ Warning ⚠️

@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Nov 4, 2025
@Alexendoo
Copy link
Member

It looks like your branch https://github.com/KDhruv3/rust-clippy/tree/fix/while-let-on-iterator doesn't have any commits past https://github.com/rust-lang/rust-clippy/commits/master/

All the listed commits here are because the PR is opened against the stable branch, I would suggest making sure you've pushed the commits to your fix/while-let-on-iterator branch and then open a PR against master. You might be able to change the target of an existing PR but I'm not sure on that one

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Lintcheck changes for ad7fc4f

Lint Added Removed Changed
clippy::assertions_on_constants 0 0 1
clippy::cast_possible_wrap 0 0 253
clippy::cast_sign_loss 0 0 294
clippy::derivable_impls 0 0 21
clippy::expl_impl_clone_on_copy 0 0 326
clippy::float_cmp 0 2 1
clippy::float_cmp_const 2 0 0
clippy::if_then_some_else_none 0 8 1
clippy::implicit_return 21 0 0
clippy::incompatible_msrv 6 6 0
clippy::inefficient_to_string 0 5 0
clippy::integer_division_remainder_used 0 0 1186
clippy::invalid_upcast_comparisons 0 1 0
clippy::let_and_return 0 2 0
clippy::let_unit_value 0 0 4
clippy::manual_assert 0 0 70
clippy::manual_is_infinite 0 2 0
clippy::match_same_arms 0 0 10
clippy::missing_const_for_fn 0 4 0
clippy::missing_trait_methods 0 0 41210
clippy::mod_module_files 0 4 25
clippy::mut_mut 0 0 11
clippy::mutex_atomic 0 14 0
clippy::needless_doctest_main 2 24 11
clippy::non_ascii_literal 0 0 15
clippy::option_option 0 0 21
clippy::ptr_offset_with_cast 0 0 2
clippy::range_plus_one 0 0 9
clippy::rest_pat_in_fully_bound_structs 0 0 2
clippy::self_named_module_files 1 4 6
clippy::semicolon_if_nothing_returned 0 0 168
clippy::test_attr_in_doctest 2 0 1
clippy::too_long_first_doc_paragraph 0 0 21
clippy::unchecked_duration_subtraction 0 3 0
clippy::unchecked_time_subtraction 7 0 0
clippy::undocumented_unsafe_blocks 0 18 1
clippy::unnecessary_mut_passed 0 0 1
clippy::unnecessary_safety_comment 16 0 269
clippy::unnecessary_unwrap 0 0 1
clippy::use_self 59 3 4
clippy::useless_conversion 0 0 3

This comment will be updated if you push new changes

@Alexendoo
Copy link
Member

Going to close this, please feel free to open a new one if you get it sorted!

@Alexendoo Alexendoo closed this Nov 15, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-merge-commits PR has merge commits, merge with caution. needs-fcp S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)

Projects

None yet

Development

Successfully merging this pull request may close these issues.