Improve docs for clippy_utils's MSRV support
#15905
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ada4a
suggested changes
Oct 25, 2025
Contributor
Author
|
Thanks for the feedback! Let me know if you want me to squash my changes together. |
Contributor
|
I think that'd make sense, yeah:) But note that I won't be able to actually approve the changes afterwards, as I'm not a team member^^ |
This comment has been minimized.
This comment has been minimized.
0b4adfa to
57c8337
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation to
extract_msrv_attr!, improves the documentation onMsrvandMsrvStack, and slightly refactorsMsrv::read_cargo(). While I've usedclippy_utilsbefore, this is my first time interacting with the MSRV side of it, so please check over my writing to make sure it is correct!Let me know if there's anything else I need to do. :)