这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@GuillaumeGomez
Copy link
Member

Fixes #7328.

r? @llogiq

changelog: Add new unnecessary_result_map_or_else lint

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 18, 2024
@GuillaumeGomez GuillaumeGomez force-pushed the unnecessary_result_map_or_else branch 4 times, most recently from 721261c to 4e8b010 Compare January 18, 2024 17:20
@GuillaumeGomez
Copy link
Member Author

Finally fixed CI. ^^'

@GuillaumeGomez GuillaumeGomez force-pushed the unnecessary_result_map_or_else branch from 4e8b010 to 2f5a5f5 Compare January 23, 2024 15:06
@GuillaumeGomez GuillaumeGomez force-pushed the unnecessary_result_map_or_else branch from 2f5a5f5 to e86da9e Compare January 23, 2024 15:13
@GuillaumeGomez
Copy link
Member Author

Updated to handle the let binding chaining. Added more ui tests.

@llogiq
Copy link
Contributor

llogiq commented Jan 27, 2024

Thank you!

@bors r+

@bors
Copy link
Contributor

bors commented Jan 27, 2024

📌 Commit e86da9e has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 27, 2024

⌛ Testing commit e86da9e with merge 85e08cd...

@bors
Copy link
Contributor

bors commented Jan 27, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 85e08cd to master...

@bors bors merged commit 85e08cd into rust-lang:master Jan 27, 2024
@GuillaumeGomez GuillaumeGomez deleted the unnecessary_result_map_or_else branch January 27, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New lint: suggest the use of Result::unwrap_or_else over Result::map_or_else

4 participants