kotlin-ci #638
kotlin-ci #638
Conversation
|
@robertbastian @Manishearth I've added a ci pipeline for kotlin. Linux only for now. Should I create one for Mac too? Windows will be a bit of a challenge cause I don't really know how to work on it. But if necessary I can figure something out. |
|
@Manishearth I'd like to keep this open a bit to see if I can get it to work on JVM 17 |
| - name: Set up JDK 17 for x64 | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: '17' |
There was a problem hiding this comment.
As far as I can see @emarteca this now uses a JVM 17 version. I've also locally configured a temurin 17 JVM in my intelliJ and successfully ran the tests. So it should be good to go
| import java.lang.foreign.MemorySession | ||
| import java.lang.foreign.SegmentAllocator |
There was a problem hiding this comment.
@emarteca the offending lines, if you want to try and remove these, maybe it'll work.
|
@Manishearth I'm re-requesting review cause I made a few small changes to make this compatible with JVM 19 |
* kotlin-ci - try adding kotlin ci steps * kotlin-ci - add cargo make * kotlin-ci - comment out other ci temporarily * korlin-ci - use so file instead of dylib * kotlin-ci - add library path * kotlin-ci - println debug * kotlin-ci - more debug testing * kotlin-ci - show stdout in gradle tests * kotlin-ci - gradle debug * kotlin-ci - commands need exec * kotlin-ci - add native path * kotlin-ci - can we add the library path as a jvm arg? * kotlin-ci use env-variables * kotlin-ci another try at env-vars * kotlin-ci - another try at env-vars * kotlin-ci - remove env-var cruft * kotlin-ci - fix cargo make env * kotlin-ci - remove debug code / add example * kotlin-ci - remove debug code * kotlin-ci - recomment * kotlin-ci - dylib -> so for example * kotlin-ci - cross-platform * kotlin-ci - fix generated lib file extension * kotlin-ci - remove debug * kotlin-ci - uncomment other checks * kotlin-ci focus on example * kotlin-ci - debug link path * kotlin-ci - test both example and feature / remove debug * kotlin-ci - enable all ci * kotlin-ci - remove plain whitespace from lines * kotlin-ci - remove unused panama related imports * kotlin-ci - example to JVM 17 * kotlin-ci - clean up some tests
Unfortunately I can't really debug the ci process other than trying to run them via PR, so I'm opening this up as a draft.I've created a linux backed ci pipeline for kotlin that tests both functionalities. I've tried to keep the ci pipeline working locally for macos but I haven't set up ci pipeline for macos. One thing I don't really know anything about is how to test this on windows. Otherwise this feels pretty minimal. Another downside is that loading gradle takes a while. I wonder if we can cache spinning up the gradle daemon, but somehow that seems unlikely.