Use File.exist? for 3.2.0 compatibility #12

ishiikurisu · 2024-06-28T18:41:50Z

Ever since updating some projects to Ruby 3.2.0, this library was broken. The fix was to include a snippet like the following in the code:

unless File.respond_to?(:exists?)
  class << File
    alias_method :exists?, :exist?
  end
end

This PR includes a version of this fix to this library which should be compatible with versions both before and after 3.2.0.

ishiikurisu · 2024-06-28T18:41:59Z

I'm unaware of other features broken because of this update, so maybe it is relevant to check for other changes?

geraldb · 2024-06-28T19:29:57Z

thanks for highlighting the breaking change with File.exists? - note - might be better to simply rename File.exists? to File.exist?, no?

ishiikurisu · 2024-06-28T19:47:17Z

Checked the documentation and using just File.exist? seems to be safe so I updated the PR accordingly. Good call!

geraldb · 2024-06-28T19:53:51Z

thks. let's give it a try. i try to push a new gem with your changes.

Use File.exists? for 3.2.0 compatibility

78698ae

ishiikurisu force-pushed the master branch from 34b7a2a to 78698ae Compare June 28, 2024 18:50

ishiikurisu changed the title ~~Use File.exists? for 3.2.0 compatibility~~ Use File.exist? for 3.2.0 compatibility Jun 28, 2024

Use File.exist?

da5b280

geraldb merged commit 3fd66eb into rubycocos:master Jun 28, 2024

Provide feedback