Add JS & CSS lint actions on PRs #51
Conversation
There was a problem hiding this comment.
I have a few more ideas in mind which can be implemented in this workflow:
- We can run linting for the package.json using
npm run lint:pkg-json, so it's makes sense to add it as well. actions/cache@v3GHA can be used for node_modules cache.- Add concurrency so that previous tests can be canceled if new changes pushed recently.
- We can specify when to run a workflow on PR i.e.
pull_request:
types:
- synchronize
- opened
- ready_for_reviewShould we run this workflow on Node 14 as well?
|
|
||
| on: | ||
| pull_request: | ||
| paths: |
There was a problem hiding this comment.
Do we need to require paths explicitly? We already have specified paths in the npm:lint* commands.
|
@RahiDroid Should we include JS tests in this workflow as well? |
Co-authored-by: Lovekesh Kumar <lovekesh.kumar@rtcamp.com>
Added!
Actions documentation states that, "It is not recommended to cache node_modules, as it can break across Node versions and won’t work with npm ci".
Yup, adding
I don't think it's necessary.
Should be part of different workflow but will add |
Description
Adds JS & CSS lint checks on PRs
Technical Details
Checklist
Screenshots
To-do
Fixes/Covers issue
Fixes #