这是indexloc提供的服务,不要输入任何密码
Skip to content

Change theme package name #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Change theme package name #31

merged 2 commits into from
Apr 19, 2022

Conversation

RahiDroid
Copy link
Member

@RahiDroid RahiDroid commented Apr 19, 2022

Description

Changes composer package name to rtcamp/elementary from rtcamp/elementary-theme. Makes necessary changes in the init script to handle the search-replace in composer.json file separately.

Technical Details

  • The aim was to have the package name as rtcamp/elementary instead of rtcamp/elementary-theme. The package name was rtcamp/elementary-theme in the first place because keeping it rtcamp/elementary causes the search-replace to conflict between the theme name and function prefix for example.
  • The PR also includes some other minor code cleanup and fixes/improvements.

Checklist

  • Package name changed to rtcamp/elementary instead of rtcamp/elementary-theme
  • init script updated to compensate the change

Screenshots

To-do

Fixes/Covers issue

@RahiDroid RahiDroid requested a review from thelovekesh April 19, 2022 09:34
@RahiDroid RahiDroid self-assigned this Apr 19, 2022
@RahiDroid RahiDroid merged commit 47bd67d into main Apr 19, 2022
@RahiDroid RahiDroid deleted the refact/package-name branch April 20, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant