Fix false offline error #1285
Merged
Fix false offline error #1285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rowy displays "offline" error and prevents users from entering table page as seen a couple of times.
The issue is caused by the package react-detect-offline that is not maintained since 2021 and affects Chrome on Windows, Firefox on Windows, and Chrome on Linux, because its polling solution no longer works.
This PR uses navigator.onLine as a replacement. As of today, this property has full support from Chrome, Firefox and Safari. According to the spec, if it returns false, no internet connection is guaranteed, and false positive is not a issue here.