这是indexloc提供的服务，不要输入任何密码
Skip to content

#ROWY-766: Modified default/empty hook and extension settings #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 23, 2022
Merged

#ROWY-766: Modified default/empty hook and extension settings #1015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6dcec2
Update CONTRIBUTING.md
harinij Nov 22, 2022
f53c9ef
Modified default/empty hook and extension settings
mshamsrainey Dec 13, 2022
5771931
Merge branch 'develop' into ROWY-766-webhook-defaults
shamsmosowi Dec 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ to start.

## Working on existing issues

If you are working on an [issue](https://github.com/rowyio/rowy/issues), share that you are working on it by commenting on the issue and posting a message on #contributions channel in Rowy's [Discord](https://discord.com/invite/fjBugmvzZP).
This allows others in the community and the maintainers a chance to provide feedback and guidance before you spend time working on it.

Before you get started working on an [issue](https://github.com/rowyio/rowy/issues), please make sure to share that you are working on it by commenting on the issue and posting a message on #contributions channel in Rowy's [Discord](https://discord.com/invite/fjBugmvzZP). The maintainers will then assign the issue to you after making sure any relevant information or context in addition is provided before you can start on the task.

Once you are assigned a task, please provide periodic updates or share any questions or roadblocks on either discord or the Github issue, so that the commmunity or the project maintainers can provide you any feedback or guidance as needed. If you are inactive for more than 1-2 week on a issue that was assigned to you, then we will assume you have stopped working on it and we will unassign it from you - so that we can give a chance to others in the community to work on it.
Expand Down
2 changes: 1 addition & 1 deletion src/components/TableModals/ExtensionsModal/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ export function emptyExtensionObject(
): IExtension {
return {
name: `${type} extension`,
active: false,
active: true,
triggers: [],
type,
extensionBody: extensionBodyTemplate[type] ?? extensionBodyTemplate["task"],
Expand Down
2 changes: 1 addition & 1 deletion src/components/TableModals/WebhooksModal/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export function emptyWebhookObject(
): IWebhook {
return {
name: `${type} webhook`,
active: false,
active: true,
endpoint: generateId(),
type,
parser: webhookSchemas[type].parser?.template(table),
Expand Down