-
Notifications
You must be signed in to change notification settings - Fork 542
Develop #1405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Develop #1405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performing the update on mouse-down caused this issue where dragging the mouse around after clicking would result in the edge of the column to move along with it. Updating on mouse-up instead avoids this issue.
- Better component name - Remove unnecessary map() call
fix bug: minimize `BuildLogsSnack` upon fullscreen
The enum generated by the previous template string would have had syntax errors if the secret contained hyphens. This commit fixes it.
…-get-secrets Add code editor quick action to get secrets
atom, not just the table headers.
1. Use generateId function instead of Math.random() 2. Remove `tablePage` from useEffect in `Table.tsx` Upon an error in the firebase query this was causing an infinite loop to increase page number. 3. Change the logic of when the clear and disable button are shown/disabled The existing logic was preventing certain tasks to be performed. For example, deleting all filters individually was disabling both apply and clear all button. As a user I expect to delete all filters and click on the apply button to save.
Co-authored-by: il3ven <vaibhavchanana@yahoo.co.in>
it shouldn't be disabled if tableFilters are present but userFilters are active.
Row selection has been disabled because bulk delete functionality cannot work for array sub table according to the current implementation. Bulk delete problem: Suppose we have an array with values `[a, b, c]`. Suppose, the indexes to be removed are [1, 2]. The UI asks firebase function to remove index 1. After 1, the UI asks index 2 to be deleted but index 2 doesn't exist. After deletion of index 1, the array is `[a, c]`.
`enableRowSelection` was introduced in the last commit. As of this commit row selection is enabled for TablePage and SubTablePage.
If there are 1000 rows and we have rendered 100 then select all will only select 100. In this case, technically all rows in react-table are selected but we should not show the checked state. It leads to bad UX. Indermediate would be better. Also, split the additions of row selection column into a new useMemo. This ensures that if a row is selected we are only re-calculating the row selection column and not all.
Due to wrong CSS we were not able to see the icon.
# Conflicts: # src/components/CodeEditor/useMonacoCustomizations.ts # yarn.lock
Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.0.1 to 4.3.1. - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md) - [Commits](https://github.com/adobe/css-tools/commits) --- updated-dependencies: - dependency-name: "@adobe/css-tools" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
fix: FEAT: Array column should be filterable
this feature has been re-implemented from PR #1256 because the older PR had bugs and didn't support multiple filters.
add support for bulk deletion of rows
Monaco code editor auto typing
add support for multiple filters
…s-tools-4.3.1 Bump @adobe/css-tools from 4.0.1 to 4.3.1
Add an accessible resizing option
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.