这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@shamsmosowi
Copy link
Contributor

No description provided.

bofeiw and others added 30 commits January 29, 2023 00:14
Performing the update on mouse-down caused this issue where dragging the mouse around after clicking would result in the edge of the column to move along with it. Updating on mouse-up instead avoids this issue.
 - Better component name
 - Remove unnecessary map() call
fix bug: minimize `BuildLogsSnack` upon fullscreen
The enum generated by the previous template string would have had
syntax errors if the secret contained hyphens.

This commit fixes it.
…-get-secrets

Add code editor quick action to get secrets
This reverts commit 6819bf1, reversing
changes made to 70498bc.
1. Use generateId function instead of Math.random()

2. Remove `tablePage` from useEffect in `Table.tsx`

Upon an error in the firebase query this was causing an infinite loop
to increase page number.

3. Change the logic of when the clear and disable button are shown/disabled

The existing logic was preventing certain tasks to be performed.

For example, deleting all filters individually was disabling both apply
and clear all button. As a user I expect to delete all filters and
click on the apply button to save.
Co-authored-by: il3ven <vaibhavchanana@yahoo.co.in>
il3ven and others added 21 commits August 22, 2023 19:43
it shouldn't be disabled if tableFilters are present but userFilters
are active.
Row selection has been disabled because bulk delete functionality
cannot work for array sub table according to the current implementation.

Bulk delete problem:

Suppose we have an array with values `[a, b, c]`. Suppose, the indexes
to be removed are [1, 2]. The UI asks firebase function to remove index
1. After 1, the UI asks index 2 to be deleted but index 2 doesn't exist.
After deletion of index 1, the array is `[a, c]`.
`enableRowSelection` was introduced in the last commit.

As of this commit row selection is enabled for TablePage and
SubTablePage.
If there are 1000 rows and we have rendered 100 then select all will
only select 100. In this case, technically all rows in react-table are
selected but we should not show the checked state. It leads to bad UX.
Indermediate would be better.

Also, split the additions of row selection column into a new useMemo. This
ensures that if a row is selected we are only re-calculating the row
selection column and not all.
Due to wrong CSS we were not able to see the icon.
# Conflicts:
#	src/components/CodeEditor/useMonacoCustomizations.ts
#	yarn.lock
Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.0.1 to 4.3.1.
- [Changelog](https://github.com/adobe/css-tools/blob/main/History.md)
- [Commits](https://github.com/adobe/css-tools/commits)

---
updated-dependencies:
- dependency-name: "@adobe/css-tools"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
fix: FEAT: Array column should be filterable
this feature has been re-implemented from PR #1256 because the older PR had
bugs and didn't support multiple filters.
add support for bulk deletion of rows
…s-tools-4.3.1

Bump @adobe/css-tools from 4.0.1 to 4.3.1
@vercel
Copy link

vercel bot commented Sep 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rowy-os 🔄 Building (Inspect) Visit Preview Sep 8, 2023 2:36am
rowy-typedoc 🔄 Building (Inspect) Visit Preview Sep 8, 2023 2:36am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants