这是indexloc提供的服务,不要输入任何密码
Skip to content

Sending trices one by one for TRICE_SINGLE_PACK_MODE double buffer #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

dbeliavskij
Copy link
Contributor

This Pull Request fixes #543 by moving the point of transfer for trices in TRICE_SINGLE_PACK_MODE after encoding each trice in buffer.
This Pull Request attempts to fix the issue in least intrusive way without any consideration for possible optimizations (for example using a separate transfer function for routing and main transfer)

@rokath
Copy link
Owner

rokath commented Jul 1, 2025

Thanks for this, @dbeliavskij, but on running testAll.sh full we get now:

../../src/triceDoubleBuffer.c: In function 'TriceOut':
../../src/triceDoubleBuffer.c:267:9: error: implicit declaration of function 'TriceNonBlockingDeferredRoute8'; did you mean 'TriceNonBlockingDeferredWrite8'? [-Wimplicit-function-declaration]
  267 |         TriceNonBlockingDeferredRoute8(triceID, dst, len);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |         TriceNonBlockingDeferredWrite8
../../src/triceDoubleBuffer.c:267:54: error: 'len' undeclared (first use in this function); did you mean 'len8'?
  267 |         TriceNonBlockingDeferredRoute8(triceID, dst, len);
      |                                                      ^~~
      |                                                      len8
../../src/triceDoubleBuffer.c:267:54: note: each undeclared identifier is reported only once for each function it appears in
make: *** [gcc1.mak:21: out.gcc/triceDoubleBuffer.o] Error 1

Would you please check.

@dbeliavskij dbeliavskij force-pushed the doubleBufferRoutingIssue branch from cecca85 to 44c824c Compare July 1, 2025 09:22
@dbeliavskij
Copy link
Contributor Author

I've fixed this typo

@rokath
Copy link
Owner

rokath commented Jul 1, 2025

Does the script testAll.sh full succeed at your machine?

../../src/triceDoubleBuffer.c: In function 'TriceOut':
../../src/triceDoubleBuffer.c:267:54: error: 'len' undeclared (first use in this function); did you mean 'len8'?
  267 |         TriceNonBlockingDeferredWrite8(triceID, dst, len);
      |                                                      ^~~
      |                                                      len8
../../src/triceDoubleBuffer.c:267:54: note: each undeclared identifier is reported only once for each function it appears in
make: *** [gcc1.mak:21: out.gcc/triceDoubleBuffer.o] Error 1
make: *** Waiting for unfinished jobs....

@rokath
Copy link
Owner

rokath commented Jul 4, 2025

testAll.sh should work out of the box. It skips steps needing not installed tools.

@dbeliavskij dbeliavskij force-pushed the doubleBufferRoutingIssue branch from 44c824c to 726c2ee Compare July 5, 2025 12:41
@dbeliavskij
Copy link
Contributor Author

Had some conflicts in my environment.

Now, testAll.sh full runs:

Fri, Jul  4, 2025  5:01:03 PM
This can take a while ...
ok      github.com/rokath/trice/cmd/trice       2.618s
ok      github.com/rokath/trice/internal/args   1.862s
ok      github.com/rokath/trice/internal/charDecoder    1.371s
ok      github.com/rokath/trice/internal/com    1.236s
ok      github.com/rokath/trice/internal/decoder        1.404s
?       github.com/rokath/trice/internal/do     [no test files]
ok      github.com/rokath/trice/internal/dumpDecoder    1.393s
ok      github.com/rokath/trice/internal/emitter        1.441s
ok      github.com/rokath/trice/internal/id     4.352s
ok      github.com/rokath/trice/internal/keybcmd        1.436s
ok      github.com/rokath/trice/internal/link   1.227s
ok      github.com/rokath/trice/internal/receiver       1.474s
?       github.com/rokath/trice/internal/translator     [no test files]
ok      github.com/rokath/trice/internal/trexDecoder    0.898s
?       github.com/rokath/trice/pkg/ant [no test files]
ok      github.com/rokath/trice/pkg/cipher      0.745s
ok      github.com/rokath/trice/pkg/endian      0.542s
ok      github.com/rokath/trice/pkg/msg 0.631s
ok      github.com/rokath/trice/pkg/tst 0.833s
ok      github.com/rokath/trice/_test/be_dblB_de_tcobs_ua       212.011s
ok      github.com/rokath/trice/_test/be_staticB_di_xtea_cobs_rtt32     211.829s
ok      github.com/rokath/trice/_test/dblB_de_cobs_ua   211.890s
ok      github.com/rokath/trice/_test/dblB_de_multi_cobs_ua     211.857s
ok      github.com/rokath/trice/_test/dblB_de_multi_nopf_ua     211.418s
ok      github.com/rokath/trice/_test/dblB_de_multi_tcobs_ua    211.697s
ok      github.com/rokath/trice/_test/dblB_de_multi_xtea_cobs_ua        211.532s
ok      github.com/rokath/trice/_test/dblB_de_multi_xtea_tcobs_ua       212.055s
ok      github.com/rokath/trice/_test/dblB_de_nopf_ua   211.789s
ok      github.com/rokath/trice/_test/dblB_de_tcobs_ua  210.522s
ok      github.com/rokath/trice/_test/dblB_de_xtea_cobs_ua      211.809s
ok      github.com/rokath/trice/_test/dblB_de_xtea_tcobs_ua     211.611s
ok      github.com/rokath/trice/_test/dblB_di_nopf_rtt32__de_cobs_ua    442.933s
ok      github.com/rokath/trice/_test/dblB_di_nopf_rtt32__de_multi_cobs_ua      442.926s
ok      github.com/rokath/trice/_test/dblB_di_nopf_rtt32__de_multi_tcobs_ua     443.355s
ok      github.com/rokath/trice/_test/dblB_di_nopf_rtt32__de_tcobs_ua   442.643s
ok      github.com/rokath/trice/_test/dblB_di_nopf_rtt32__de_xtea_cobs_ua       396.100s
ok      github.com/rokath/trice/_test/dblB_di_nopf_rtt8__de_cobs_ua     395.362s
ok      github.com/rokath/trice/_test/dblB_di_nopf_rtt8__de_multi_cobs_ua       395.677s
ok      github.com/rokath/trice/_test/dblB_di_nopf_rtt8__de_multi_tcobs_ua      395.271s
ok      github.com/rokath/trice/_test/dblB_di_nopf_rtt8__de_tcobs_ua    395.811s
ok      github.com/rokath/trice/_test/ringB_de_cobs_ua  208.400s
ok      github.com/rokath/trice/_test/ringB_de_multi_tcobs_ua   208.194s
ok      github.com/rokath/trice/_test/ringB_de_multi_xtea_cobs_ua       208.208s
ok      github.com/rokath/trice/_test/ringB_de_multi_xtea_tcobs_ua      208.311s
ok      github.com/rokath/trice/_test/ringB_de_nopf_ua  208.291s
ok      github.com/rokath/trice/_test/ringB_de_tcobs_ua 208.155s
ok      github.com/rokath/trice/_test/ringB_de_xtea_cobs_ua     208.226s
ok      github.com/rokath/trice/_test/ringB_de_xtea_tcobs_ua    187.903s
ok      github.com/rokath/trice/_test/ringB_di_cobs_rtt32__de_tcobs_ua  373.283s
ok      github.com/rokath/trice/_test/ringB_di_cobs_rtt8__de_tcobs_ua   373.269s
ok      github.com/rokath/trice/_test/ringB_di_nopf_rtt32__de_tcobs_ua  373.263s
ok      github.com/rokath/trice/_test/ringB_di_nopf_rtt32__de_xtea_cobs_ua      369.074s
ok      github.com/rokath/trice/_test/ringB_di_nopf_rtt8__de_tcobs_ua   368.777s
ok      github.com/rokath/trice/_test/ringB_di_tcobs_rtt32__de_tcobs_ua 369.309s
ok      github.com/rokath/trice/_test/ringB_di_xtea_cobs_rtt32__de_xtea_cobs_ua 368.908s
ok      github.com/rokath/trice/_test/special_for_debug 0.473s
ok      github.com/rokath/trice/_test/special_protect_dblB_de_tcobs_ua  0.490s
ok      github.com/rokath/trice/_test/stackB_di_nopf_aux32      186.183s
ok      github.com/rokath/trice/_test/stackB_di_nopf_aux8       186.366s
ok      github.com/rokath/trice/_test/stackB_di_nopf_rtt32      185.714s
ok      github.com/rokath/trice/_test/stackB_di_nopf_rtt8       185.137s
ok      github.com/rokath/trice/_test/stackB_di_xtea_cobs_rtt8  183.585s
ok      github.com/rokath/trice/_test/staticB_di_nopf_aux32     183.254s
ok      github.com/rokath/trice/_test/staticB_di_nopf_aux8      183.550s
ok      github.com/rokath/trice/_test/staticB_di_nopf_rtt32     183.167s
ok      github.com/rokath/trice/_test/staticB_di_nopf_rtt8      183.148s
ok      github.com/rokath/trice/_test/staticB_di_tcobs_rtt32    182.027s
ok      github.com/rokath/trice/_test/staticB_di_tcobs_rtt8     180.468s
ok      github.com/rokath/trice/_test/staticB_di_xtea_cobs_rtt32        180.316s
Script run 1424 seconds.

@rokath rokath merged commit 41cfd4f into rokath:master Jul 8, 2025
1 check passed
@dbeliavskij dbeliavskij deleted the doubleBufferRoutingIssue branch July 10, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Routing with double buffer does not route correct trices
2 participants