Add flag to disable CYCLE_ERROR in log #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this proposal, @dbeliavskij. Would not Of course, if you wish to have cycle counter checks normally and to suppress those checks on a Trices subset later, this flag makes sense. If you agree, I would accept this pull request, but rename the switch into |
|
Yes, your proposed naming is clearer, I've pushed the commit with the change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a flag
-noCyclefortrice logtool to disable cycle errorsThe use case:
When routing certain Trice by their ID to some other medium (for example storing error trices in flash) and later parsing the log it would result in constant
CYCLE_ERRORmessages. This flag allows to suppress these messages