chore: log prNotPendingHours
#39287
Open
chore: log prNotPendingHours
#39287
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This is related to #39242 right? |
jamietanna
approved these changes
Nov 13, 2025
Contributor
jamietanna
left a comment
There was a problem hiding this comment.
Follows what we're doing elsewhere in this file ✅
This won't trigger a release (chore doesn't trigger) but is OK to wait for the next release
jamietanna
reviewed
Nov 13, 2025
| ) { | ||
| logger.debug( | ||
| `Branch is ${elapsedHours} hours old - skipping PR creation`, | ||
| `Branch is ${elapsedHours} hours old - skipping PR creation as prNotPendingHours is set to ${String(config.prNotPendingHours)}`, |
Contributor
There was a problem hiding this comment.
It'd be nice if we added prNotPendingHours to the config object, so we have type information (as a follow-up)
Member
There was a problem hiding this comment.
is the String() call really required?
Collaborator
Author
There was a problem hiding this comment.
yeah. ts complains otherwise
Member
There was a problem hiding this comment.
so simply add it to type definition and the error is gone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
prNotPendingHours, we should log it along with theelapsed hoursContext
Please select one of the below:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: