这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@jonaskuske
Copy link
Contributor

@jonaskuske jonaskuske commented Nov 12, 2025

Changes

When using standard-compliant dependencies via project.dependencies, project.optional-dependencies or dependency-groups, Poetry will prefer them over the Poetry specific tool.poetry values. However, it allows using the tool.poetry fields to add additional info for a dependency, most importantly a custom source (similar to tool.uv.sources in uv): https://python-poetry.org/docs/dependency-specification/#:~:text=When%20both%20are%20specified

[project]
dependencies = ["mydep"]

[tool.poetry.dependencies]
mydep = { source = "artifactory" }

This PR makes Renovate compatible with this behavior, using tool.poetry entries to enrich a dependency declaration found in one of the standard-based fields.

Context

Please select one of the below:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository: (private repo)

Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your fix.

Could you please separate the requires-python logic to another PR? We like to keep separate topics in different PRs so it's faster/easier to review and also makes reverts easier in-case something breaks.

@jonaskuske jonaskuske force-pushed the feat/requires-python-for-poetry-and-enriched-dep-meta branch from d217505 to fbddbde Compare November 13, 2025 07:08
@jonaskuske jonaskuske force-pushed the feat/requires-python-for-poetry-and-enriched-dep-meta branch from fbddbde to 2482beb Compare November 13, 2025 07:12
@jonaskuske jonaskuske changed the title feat: requires-python for poetry and enriched dep meta feat: enrich deps with managerData from poetry deps if both present Nov 13, 2025
@jonaskuske
Copy link
Contributor Author

Done, removed requires-python changes from this PR!

@RahulGautamSingh RahulGautamSingh self-requested a review November 13, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants