这是indexloc提供的服务，不要输入任何密码
Skip to content

feat: allow configFileNames to be set through env #39144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: allow configFileNames to be set through env #39144

wants to merge 9 commits into from
+41 −31

Conversation

@scootermon
Copy link

@scootermon scootermon commented Nov 6, 2025

Changes

This PR changes the configFileNames config option (introduced recently in #36644) to support setting it through environment variables as well.
There is a chance I'm missing an obvious reason why it was done this way, but neither the PR nor the corresponding issue mentions one.

Context

Please select one of the below:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository:

@CLAassistant
Copy link

CLAassistant commented Nov 6, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@RahulGautamSingh RahulGautamSingh self-requested a review November 7, 2025 05:36
RahulGautamSingh
RahulGautamSingh suggested changes Nov 7, 2025
View reviewed changes
@RahulGautamSingh
Copy link
Collaborator

RahulGautamSingh commented Nov 7, 2025

Please, also test this on a test repo, to be sure.

@scootermon
Copy link
Author

scootermon commented Nov 7, 2025

Please, also test this on a test repo, to be sure.

See: https://github.com/scootermon/renovate-test-39144

The onboarding PR is using the correct filename: scootermon/renovate-test-39144#1

and a subsequent run managed to find the file:

DEBUG: Found my-cool-renovate.json5 config file (repository=scootermon/renovate-test-39144)
DEBUG: Repository config (repository=scootermon/renovate-test-39144)
       "fileName": "my-cool-renovate.json5",
       "config": {"$schema": "https://docs.renovatebot.com/renovate-schema.json"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viceice viceice Awaiting requested review from viceice

@secustor secustor Awaiting requested review from secustor

1 more reviewer

@RahulGautamSingh RahulGautamSingh RahulGautamSingh approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scootermon @CLAassistant @RahulGautamSingh