这是indexloc提供的服务，不要输入任何密码
Skip to content

feat(forgejo): support teams as reviewer #37589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025
Merged

feat(forgejo): support teams as reviewer #37589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/modules/platform/forgejo/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2898,12 +2898,15 @@ describe('modules/platform/forgejo/index', () => {
.scope('https://code.forgejo.org/api/v1')
.post('/repos/some/repo/pulls/1/requested_reviewers', {
reviewers: ['me', 'you'],
team_reviewers: ['org/team'],
})
.reply(200);
await initFakePlatform(scope);
await initFakeRepo(scope);

await expect(forgejo.addReviewers(1, ['me', 'you'])).toResolve();
await expect(
forgejo.addReviewers(1, ['me', 'you', 'org/team']),
).toResolve();

expect(logger.logger.warn).not.toHaveBeenCalled();
});
Expand Down
6 changes: 5 additions & 1 deletion lib/modules/platform/forgejo/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1056,7 +1056,11 @@ const platform: Platform = {
async addReviewers(number: number, reviewers: string[]): Promise<void> {
logger.debug(`Adding reviewers '${reviewers?.join(', ')}' to #${number}`);
try {
await helper.requestPrReviewers(config.repository, number, { reviewers });
const teamReviewers = new Set(reviewers.filter((r) => r.includes('/')));
await helper.requestPrReviewers(config.repository, number, {
reviewers: reviewers.filter((r) => !teamReviewers.has(r)),
...(teamReviewers.size && { team_reviewers: [...teamReviewers] }),
});
} catch (err) {
logger.warn({ err, number, reviewers }, 'Failed to assign reviewer');
}
Expand Down