How to enable auto-closing of older, superseded PRs? #39257
-
How are you running Renovate?A Mend.io-hosted app Which platform you running Renovate on?GitHub.com Which version of Renovate are you using?41.173.1 Please tell us more about your question or problemHello! I'm trying to ensure that when Renovate creates a new PR for a dependency, it automatically closes any older, open PRs for the same dependency. For example, our bot created a PR for my-dependency I've been looking through our config (which uses config:recommended, [ My question is: Is :prConcurrentLimitNone the reason this auto-closing is not happening? If I remove it, will Renovate resume its default behavior of cleaning up old PRs? I'm hesitant to just merge and test, as this config affects our entire repo's dependency updates. I've searched for similar discussions but couldn't find a direct confirmation. Thanks for the help! Logs (if relevant)Logs |
Beta Was this translation helpful? Give feedback.
Replies: 3 comments 4 replies
-
|
The bot doesn't close older, superseded PRs like that ie. 2 open PRs for same package can exist at same time. You need to merge the PR with higher version and then the remaining PR will be auto-closed. If instead you merge the PR with lower version, the PR will higher version will remain open.
If you can give redacted logs of the section |
Beta Was this translation helpful? Give feedback.
-
|
Could you share the branch names of the two PRs? |
Beta Was this translation helpful? Give feedback.
-
|
Thank you so much for the clarification! That makes perfect sense. I see the "Edited/Blocked Notification" on our older PR, which explains why it wasn't auto-closed. To answer your questions, here is the information from my last dry-run log:
auto-update/toolbox-server-v0.18.0 (PR #145) auto-update/toolbox-server-v0.19.1 (PR #149)
Here's a gist for recent dry-run logs: https://gist.github.com/SaxenaAnushka102/2b2e36db0ccc20387b47f0aded309b4f |
Beta Was this translation helpful? Give feedback.
-
|
Looking at the You can get an auto-generated migration PR by adding |
Beta Was this translation helpful? Give feedback.
-
|
Oh okay, is this happening because we're using And as you mentioned, the different PRs are created for the same package only if it's a different major but in our case we're considering all minors and patches as well. Do we need to explicitly create a rule for auto-closing in this case? I'm saying this because the same behaviour has been seen in multiple repos where the previous minor's PR wasn't auto-closed even on creation of a new PR for the patch of the same minor. |
Beta Was this translation helpful? Give feedback.
-
That is because of this setting in your config, which instructs the bot to create new branch name for each upgrade. Renovate uses That's why do not recommend direct editing of |
Beta Was this translation helpful? Give feedback.
-
|
Oh okay, got your point. Thanks a lot for the info! to So now as the the default onboarding branch name doesn't change, the bot will perform autoclosing as expected? |
Beta Was this translation helpful? Give feedback.
The bot doesn't close older, superseded PRs like that ie. 2 open PRs for same package can exist at same time.
You need to merge the PR with higher version and then the remaining PR will be auto-closed. If instead you merge the PR with lower version, the PR will higher version will remain open.
prConcurrentLimitNoneis not causing this, something else is. By default renovate only creates different PRs for the same package if it's a different major so it is unexpected if what you shared is your full config. But, to get to the cause we will need logs.If you can give redacted logs of the section
packageFiles with updatesor JobID from thedeveloper.mend.ioportal then only we can help debug …