Feature/3389/search resource dialogs #3393
Conversation
|
|
||
| @resource_area_selected = from_dialog? | ||
|
|
||
| render @callback.presence || 'insert' |
There was a problem hiding this comment.
Hi @parndt ! I don't find how i could render the template by context insert or in /refinery/admin/pages_dialogs/link_to template.
Using @callback is not the good way, could you help me to find?
There was a problem hiding this comment.
oops you accidentally mentioned the @callback user 😉
There was a problem hiding this comment.
Oops! i will not expect a callback from this user 😆
| @web_address_text = "http://" | ||
| @web_address_text = params[:current_link] if params[:current_link].to_s =~ /^http:\/\// | ||
| @web_address_text = "https://" | ||
| @web_address_text = params[:current_link] if params[:current_link].to_s =~ /^https:\/\// |
There was a problem hiding this comment.
shouldn't the s be optional? Like /^https?:\/\//
|
reopened to activate code climate |
020b254 to
10a6eee
Compare
|
Hi @parndt, could you review my PR? Also, i think the PR config of codeclimate is too strict, could we just warning us? |
|
The code looks fine. I think the code climate failures provide good points 😉 |
|
I dont't really know if we still need these lines : I don't really know if it still works since There is no spec for this lines : https://github.com/refinery/refinerycms/search?q=condition&unscoped_q=condition |
|
So @parndt will you acceptthis PR as it? :) |
|
Yeah. I think that the other things can be done as separate refactors. I was looking at it the other night, but it was quite intense. |
This fixes #3389