Bugfix/specs #458
Merged
Bugfix/specs #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,7 @@ | |||
| source "https://rubygems.org" | |||
|
|
|||
| gem "refinerycms-authentication-devise", '~> 1.0.4' | |||
Member
There was a problem hiding this comment.
I know why you put this, but this is a bit dangerous, because it makes this extension rely on this implementation implicitly.
Just noting this down.
Member
There was a problem hiding this comment.
This is fine, by the way, if the library works without it and we're just using it to test when it's present.
61a65f3 to
feee12b
Compare
Member
Author
|
You.. yes you! You have the power to make it all* green : https://travis-ci.org/refinery ! XD |
Member
|
I have the power! |
Member
Author
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.