这是indexloc提供的服务，不要输入任何密码
Skip to content

[pull] master from looker-open-source:master #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025
Merged

[pull] master from looker-open-source:master #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions lib/actions/slack/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ const handleExecute = async (request, slack) => {
reject(e);
});
const directChannel = postResponse === null || postResponse === void 0 ? void 0 : postResponse.channel;
const resp2 = await slack.files.completeUploadExternal({
await slack.files.completeUploadExternal({
files: [{
id: res.file_id ? res.file_id : "",
title: fileName,
Expand All @@ -188,10 +188,6 @@ const handleExecute = async (request, slack) => {
winston.error(`${LOG_PREFIX} ${e.message}`, { webhookId });
reject(e);
});
winston.info(`response complete : ${JSON.stringify(resp2)}`);
// Workaround for regression in V2 upload, the initial
// comment does not support markdown formatting, breaking
// customer links
}
else {
await slack.files.completeUploadExternal({
Expand Down
6 changes: 1 addition & 5 deletions src/actions/slack/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ export const handleExecute = async (request: Hub.ActionRequest, slack: WebClient
reject(e)
})
const directChannel = postResponse?.channel
const resp2 = await slack.files.completeUploadExternal({
await slack.files.completeUploadExternal({
files: [{
id: res.file_id ? res.file_id : "",
title: fileName,
Expand All @@ -208,10 +208,6 @@ export const handleExecute = async (request: Hub.ActionRequest, slack: WebClient
winston.error(`${LOG_PREFIX} ${e.message}`, {webhookId})
reject(e)
})
winston.info(`response complete : ${JSON.stringify(resp2)}`)
// Workaround for regression in V2 upload, the initial
// comment does not support markdown formatting, breaking
// customer links
} else {
await slack.files.completeUploadExternal({
files: [{
Expand Down