这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@ndyakov
Copy link
Member

@ndyakov ndyakov commented May 27, 2025

Add issue templates
Add release drafter
Remove version files

@ndyakov ndyakov requested a review from Copilot May 27, 2025 10:13
@github-actions
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/redis/go-redis-entraid 93.18% (-0.08%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/redis/go-redis-entraid/version.go 0.00% (-100.00%) 0 (-1) 0 (-1) 0 💀 💀 💀 💀 💀

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/redis/go-redis-entraid/version_test.go

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors the release process by removing the existing version files, adding a Release Drafter workflow, and introducing GitHub issue templates.

  • Remove hardcoded version constant and its test
  • Add automated Release Drafter workflow and configuration
  • Provide standardized feature request and bug report templates

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
version_test.go Deleted test for Version()
version.go Deleted version constant and Version() function
.github/workflows/release-drafter.yml New workflow file to auto-draft releases
.github/release-drafter.yml Configuration for the Release Drafter action
.github/ISSUE_TEMPLATE/feature_request.md New feature request issue template
.github/ISSUE_TEMPLATE/config.yml Settings to disable blank issues and link docs/repo
.github/ISSUE_TEMPLATE/bug_report.md New bug report issue template
Comments suppressed due to low confidence (2)

version_test.go:1

  • Removing the version test eliminates coverage for version functionality; ensure the new release process includes tests or integration checks for version resolution.
-package entraid

version.go:1

  • The Version() API and its backing constant have been removed; update any callers or provide migration guidance to prevent breaking changes.
-package entraid

@@ -0,0 +1,26 @@
name: Release Drafter
Copy link

Copilot AI May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding a brief comment or linking to higher-level docs explaining how this workflow fits into the overall release and versioning process.

Copilot uses AI. Check for mistakes.
@@ -0,0 +1,46 @@
name-template: 'v$RESOLVED_VERSION'
Copy link

Copilot AI May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Having two release-drafter configuration files in different directories may be confusing; consider consolidating them or documenting their distinct roles.

Copilot uses AI. Check for mistakes.
@ndyakov ndyakov merged commit b2c911f into main May 27, 2025
7 checks passed
@ndyakov ndyakov changed the title refactor(release): refactoring release process a big. refactor(release): refactoring release process a bit. May 27, 2025
@ndyakov ndyakov deleted the ndyakov/github-housekeeping branch May 30, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants