refactor(manager): small refactors around the manager and token logic #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ndyakov
commented
May 30, 2025
- it is safer to set the receivedAt when creating the token
- make sure the manager main loop won't panic
- Updated IsClosed function to accurately check if a channel is closed without consuming data unless necessary. - Safely close the closedChan only if it is not already closed to avoid potential panics.
- Implemented panic recovery in the Start method of entraidTokenManager to prevent crashes and ensure listener is notified of errors.
- Updated the New function to return nil if expiresOn is zero to prevent panic. - Added logic to set receivedAt to the current time and recalculate TTL if receivedAt is zero. - Improved documentation to clarify the responsibilities of the caller regarding token validity and behavior when parameters are zero.
ndyakov
commented
May 31, 2025
ndyakov
commented
May 31, 2025
ndyakov
commented
May 31, 2025
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
htemelski-redis
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.