feat(servicenow): added servicenow support for extensiosn plugin #3172
Conversation
Signed-off-by: Yi Cai <yicai@redhat.com>
|
The image is available at: |
Signed-off-by: Yi Cai <yicai@redhat.com>
|
The image is available at: |
Signed-off-by: Yi Cai <yicai@redhat.com>
|
The image is available at: |
| tags: [] | ||
| spec: | ||
| packageName: "@backstage-community/plugin-servicenow-backend" | ||
| dynamicArtifact: ./dynamic-plugins/dist/backstage-community-plugin-servicenow-backend-dynamic |
There was a problem hiding this comment.
| dynamicArtifact: ./dynamic-plugins/dist/backstage-community-plugin-servicenow-backend-dynamic | |
| dynamicArtifact: oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/<Image_path_servicenow> |
| tags: [] | ||
| spec: | ||
| packageName: "@backstage-community/plugin-servicenow" | ||
| dynamicArtifact: ./dynamic-plugins/dist/backstage-community-plugin-servicenow |
There was a problem hiding this comment.
| dynamicArtifact: ./dynamic-plugins/dist/backstage-community-plugin-servicenow | |
| dynamicArtifact: oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/<Image_path_servicenow> |
should we wire the image we have from overlay repo? as done for lightspeed?
There was a problem hiding this comment.
Yeah, we would need to use OCI image here since we don't want to use wrappers for service now plugin. Right now its relying on the wrapper being available in dynamic-plugins folder.
Signed-off-by: Yi Cai <yicai@redhat.com>
|
The image is available at: |
Signed-off-by: Yi Cai <yicai@redhat.com>
|
The image is available at: |
| links: | ||
| - url: https://red.ht/rhdh | ||
| title: Homepage | ||
| - url: https://issues.redhat.com/browse/RHIDP |
There was a problem hiding this comment.
| - url: https://issues.redhat.com/browse/RHIDP | |
| - url: https://issues.redhat.com/browse/RHDHBUGS |
or can use https://github.com/backstage/community-plugins/issues as well
There was a problem hiding this comment.
Neither https://issues.redhat.com/browse/RHDHBUGS or https://github.com/backstage/community-plugins/issues is used anywhere in the current extension yaml files. Do we want to keep it consistent and update the other links to use same https://issues.redhat.com/browse/RHDHBUGS one?
There was a problem hiding this comment.
Will create a ticket for the deprecated bug link in all extension yaml files.
| links: | ||
| - url: https://red.ht/rhdh | ||
| title: Homepage | ||
| - url: https://github.com/janus-idp/backstage-plugins/issues |
There was a problem hiding this comment.
| - url: https://github.com/janus-idp/backstage-plugins/issues | |
| - url: https://issues.redhat.com/browse/RHDHBUGS |
or can use https://github.com/backstage/community-plugins/issues as well
| - title: Homepage | ||
| url: https://red.ht/rhdh | ||
| - title: Bugs | ||
| url: https://issues.redhat.com/browse/RHIDP |
There was a problem hiding this comment.
| url: https://issues.redhat.com/browse/RHIDP | |
| url: https://issues.redhat.com/browse/RHDHBUGS |
or can use https://github.com/backstage/community-plugins/issues as well
| spec: | ||
| support: tech-preview | ||
| lifecycle: active | ||
| author: Red Hat | ||
| publisher: Red Hat |
There was a problem hiding this comment.
not sure if we can have tech-preview as support for servicenow as for now it's delivered as community plugins? and is it fine to have author as Red Hat
@rohitkrai03 / @christoph-jerolimov / @christophe-f / @benwilcock
There was a problem hiding this comment.
Is it packaged using a wrapper or is it an OCI artifact?
There was a problem hiding this comment.
Updated to dev-preview. According this documentation, if it's coming from ghcr.io then it should be developer preview support.
Thanks to @nickboldt for the answer.
Signed-off-by: Yi Cai <yicai@redhat.com>
|
The image is available at: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invincibleJai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/test e2e-tests |
1 similar comment
|
/test e2e-tests |
|
@ciiay: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Added Servicenow plugin support for release 1.7.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer