Implement backend for FileJump (#8114) #8693

masrlinu · 2025-07-17T21:10:02Z

What is the purpose of this change?

This PR implements a backend for the storage provider FileJump.com.

Was the change discussed in an issue or in the forum before?

Yes, this backend was requested in issue #8114.

Checklist

I have read the contribution guidelines.
I have added tests for all changes in this PR if appropriate.
I have added documentation for the changes if appropriate.
All commit messages are in house style.
I'm done, this Pull Request is ready for review :-)

- Implemented complete filejump backend with API integration - Added comprehensive test suite for filejump backend - Updated documentation and configuration - All integration tests passing for filejump backend

ncw · 2025-07-20T16:15:49Z

How are the integration tests going? Does go test -v in the backend directory work? How about test_all?

See here for more info: https://github.com/rclone/rclone/blob/master/CONTRIBUTING.md#writing-a-new-backend

masrlinu · 2025-07-21T18:22:21Z

Yes, everything works. I just tested it again. But I had to start it with a bigger timeout. I tested it with
test_all -backends filejump -timeout 10h

It finished in 1h48min.

Here is the output of the test:
2025-07-21-140856.zip

ncw · 2025-07-25T10:38:32Z

Yes, everything works. I just tested it again. But I had to start it with a bigger timeout. I tested it with test_all -backends filejump -timeout 10h

It finished in 1h48min.

That is a bit slow, but not the slowest backend!

Here is the output of the test: 2025-07-21-140856.zip

That looks really good. The bisync tests took the longest.

We can add a time modifier in the config.yaml for the integration tests

rclone/fstest/test_all/config.yaml

Line 201 in ff9cbab

extratime: 2.0

This multiplies the normal timeout (which is 1h) by that factor. Looking at the timings none of the tests took longer than 2h so that should be fine.

This backend was made using the public REST API at https://eu.filejump.com/api-docs - is that right?

I'll give the code a review now.

ncw

This is looking really great. The integration tests all passing is fantastic.

I've put some notes inline - nothing serious.

I think you've got some lint things to fix too.

Thank you

ncw · 2025-07-25T10:43:38Z

backend/filejump/api/types.go

+func (i *Item) ModTime() (t time.Time) {
+	// Parse UpdatedAt first
+	if i.UpdatedAt != "" {
+		// Try multiple time formats that FileJump might use


Do we need multiple formats?

If so you should probably factor this parsing out as I can see it repeated below

ncw · 2025-07-25T10:45:57Z

backend/filejump/filejump.go

+		Options: []fs.Option{{
+			Name:     "access_token",
+			Help:     "You should create an API access token here: https://drive.filejump.com/account-settings",
+			Required: true,


This needs Sensitive: true

ncw · 2025-07-25T10:46:44Z

backend/filejump/filejump.go

+	hasMetaData     bool
+	size            int64
+	modTime         time.Time
+	preserveModTime bool // Flag to indicate if modTime should be preserved


What is this for?

ncw · 2025-07-25T10:50:41Z

backend/filejump/filejump.go

+    return err
+}
+*/
+func CallJSON[T any, B any](f *Fs, ctx context.Context, method string, path string, params *url.Values, body *B) (*T, error) {


Interesting use of generics. I don't think they are strictly needed, but I see it allows you return the *T from the function (rather than pass it in) which looks nice.

ncw · 2025-07-25T10:51:26Z

backend/filejump/filejump.go

+		Path:   path,
+		ExtraHeaders: map[string]string{
+			"Accept":          "application/json",
+			"Accept-Encoding": "gzip, deflate, br, zstd",


Can Go deal with those other formats? I only ever use gzip.

ncw · 2025-07-25T11:11:24Z

docs/content/filejump.md

+
+### Restricted filenames
+
+FileJump has a minimum filename length requirement of 3 characters. Rclone will automatically pad shorter filenames with spaces to meet this requirement.


That is the first time I've seen that restriction in a cloud storage system!

I think this needs to be a little bit clearer

Rclone will automatically pad shorter filenames with spaces on upload to meet this requirement. It will also remove the spaces on download. This means if you happen to have a 1 or 2 character file name ending in a space then syncing may go wrong.

ncw · 2025-07-25T11:17:19Z

backend/filejump/filejump.go

+	// FileJump doesn't support setting custom modification times via API
+	// The modification time is set by the server when the file is uploaded
+	// Return this error to indicate that setting mod time requires re-upload
+	return fs.ErrorCantSetModTimeWithoutDelete


You should just return fs.ErrorCantSetModTime here. The fs.ErrorCantSetModTimeWithoutDelete is for backends which can only set modification times when they upload a file.

ncw · 2025-07-25T11:23:49Z

docs/content/filejump.md

+
+- FileJump doesn't support setting custom modification times
+- Upload time is used as the modification time
+- `--update` flag behavior may be affected


Using the --update flag can improve sync accuracy.

ncw · 2025-07-25T11:27:13Z

backend/filejump/filejump.go

+	iDir, _ := strconv.Atoi(rootID)
+	request := RequestDelete{
+		EntryIds:      []int{iDir},
+		DeleteForever: true,


Generally backends default to storing deletes in the trash and use a hard_delete flag to override.

Eg

--jottacloud-hard-delete Delete files permanently rather than putting them into the trash --mega-hard-delete Delete files permanently rather than putting them into the trash

We started doing it that way round after one user deleted all of their files by accident! So safety first, but overridable by the user.

ncw · 2025-07-25T11:33:40Z

fstest/test_all/config.yaml

@@ -162,6 +162,8 @@ backends:
 - backend:  "gofile"
   remote:   "TestGoFile:"
   fastlist: true
+ - backend:  "filejump"
+   remote:   "TestFileJump:"


Might want extra time here as discussed above!

masrlinu · 2025-07-25T12:46:21Z

This backend was made using the public REST API at https://eu.filejump.com/api-docs - is that right?

Yes, that is right. But Google Chrome even shows the typescript of the original Code of the website and it is easy to see in the network tab in the browser after every request, what exactly happened.

So there are two different ways how to upload a file. One is by requesting an upload url and upload it there (directly to the underlying wasabi backend). The website does it this way. And the other way to upload a file is via the public REST API. It looks like a wrapper, which uploads the file later to the wasabi backend.

I did it like the website. With big files, it maybe should be faster, because the files don't use the wrapper. But maybe for short files, I should use the REST API.

As I am at the moment on holidays and can just program on my phone, I will look into your change review later.

But actually this artificial intelligence agent:

https://www.atlassian.com/blog/announcements/rovo-dev-command-line-interface

helped me A LOT with programming. I told it to make my code pass the tests and the same day, my code passed ALL the tests!

Sometimes, I had to guide it, but it is unbelievable, you should test it 😄 It is completely free until the end of this month.

And if you like, while I am on holidays, you can update my code, however you like. But don't worry, just if you have time ☺️

ncw · 2025-07-25T14:35:08Z

@masrlinu thanks for the update. I'll mark this for v1.71 which is due 23rd August. So enjoy your holiday and don't feel you need to look at this until you get back :-)

Add filejump backend implementation

e6bfbc1

- Implemented complete filejump backend with API integration - Added comprehensive test suite for filejump backend - Updated documentation and configuration - All integration tests passing for filejump backend

masrlinu mentioned this pull request Jul 17, 2025

help development for Rclone Xerovoxx98/FileJumpSync#10

Closed

ncw requested changes Jul 25, 2025

View reviewed changes

ncw added this to the v1.71 milestone Jul 25, 2025


		### Restricted filenames

		FileJump has a minimum filename length requirement of 3 characters. Rclone will automatically pad shorter filenames with spaces to meet this requirement.

Uh oh!

Implement backend for FileJump (#8114) #8693

Are you sure you want to change the base?

Implement backend for FileJump (#8114) #8693

Uh oh!

Conversation

masrlinu commented Jul 17, 2025

What is the purpose of this change?

Was the change discussed in an issue or in the forum before?

Checklist

Uh oh!

ncw commented Jul 20, 2025

Uh oh!

masrlinu commented Jul 21, 2025

Uh oh!

ncw commented Jul 25, 2025

Uh oh!

ncw left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

masrlinu commented Jul 25, 2025

Uh oh!

ncw commented Jul 25, 2025

Uh oh!

Uh oh!